Solve static analysis (#940)

Author: VincentLanglet

src/Block/Service/AbstractCategoriesBlockService.php

@@ -57,8 +57,6 @@ public function execute(BlockContextInterface $blockContext, ?Response $response
 
         $template = $blockContext->getTemplate();
 
-        \assert(\is_string($template));
-
         return $this->renderResponse($template, [
             'context' => $blockContext,
             'settings' => $blockContext->getSettings(),

src/Block/Service/AbstractCollectionsBlockService.php

@@ -60,8 +60,6 @@ public function execute(BlockContextInterface $blockContext, ?Response $response
 
         $template = $blockContext->getTemplate();
 
-        \assert(\is_string($template));
-
         return $this->renderResponse($template, [
             'context' => $blockContext,
             'settings' => $blockContext->getSettings(),

src/Block/Service/AbstractTagsBlockService.php

@@ -60,8 +60,6 @@ public function execute(BlockContextInterface $blockContext, ?Response $response
 
         $template = $blockContext->getTemplate();
 
-        \assert(\is_string($template));
-
         return $this->renderResponse($template, [
             'context' => $blockContext,
             'settings' => $blockContext->getSettings(),

tests/App/AppKernel.php

@@ -77,9 +77,6 @@ protected function configureRoutes(RoutingConfigurator $routes): void
         $routes->import(__DIR__.'/config/routes.yaml');
     }
 
-    /**
-     * @psalm-suppress DeprecatedClass
-     */
     protected function configureContainer(ContainerBuilder $container, LoaderInterface $loader): void
     {
         $loader->load(__DIR__.'/config/config.yaml');
@@ -88,6 +85,9 @@ protected function configureContainer(ContainerBuilder $container, LoaderInterfa
             $loader->load(__DIR__.'/config/config_symfony_v5.yaml');
         }
 
+        /*
+         * TODO: Remove when dropping support SonataBlock v4
+         */
         if (class_exists(HttpCacheHandler::class)) {
             $loader->load(__DIR__.'/config/config_sonata_block_v4.yaml');
         }