Skip to content

Commit 8e73abc

Browse files
authored
DevKit updates for 4.x branch (#906)
1 parent f45cf58 commit 8e73abc

3 files changed

Lines changed: 15 additions & 12 deletions

File tree

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ Closes #{put_issue_number_here}.
2323

2424
<!-- MANDATORY
2525
Fill the changelog part inside the code block.
26-
Follow this schema: http://keepachangelog.com/
26+
Follow this schema: https://keepachangelog.com/
2727
This will end up on https://github.com/sonata-project/SonataClassificationBundle/releases,
2828
please keep it short and clear and to the point
2929
-->
@@ -34,10 +34,13 @@ Closes #{put_issue_number_here}.
3434
(eg. update to docs, tests)
3535
-->
3636

37-
<!-- REMOVE EMPTY SECTIONS -->
37+
<!-- REMOVE EMPTY SECTIONS
38+
- Don't repeat the verb in the messages (don't use "Added", "Changed", etc).
39+
- Don't use a full stop at the end of the messages.
40+
-->
3841
```markdown
3942
### Added
40-
- Added some `Class::newMethod()` to do great stuff.
43+
- Some `Class::newMethod()` to do great stuff
4144

4245
### Changed
4346

CONTRIBUTING.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ you using the latest patch version?
3535

3636
GitHub Issues is for **issues**, as opposed to question on how to use Sonata.
3737
If you are not sure this is a bug, or simply want to ask such a question,
38-
please post your question on [Stack Overflow](http://stackoverflow.com/questions/tagged/sonata),
38+
please post your question on [Stack Overflow](https://stackoverflow.com/questions/tagged/sonata),
3939
using the `sonata` tags.
4040

4141
If you happen to find a bug, we kindly request you report it. However,
@@ -79,11 +79,11 @@ But please, read the following before.
7979

8080
#### Coding style
8181

82-
Each project follows [PSR-1](http://www.php-fig.org/psr/psr-1/), [PSR-2](http://www.php-fig.org/psr/psr-2/)
83-
and [Symfony Coding Standards](http://symfony.com/doc/current/contributing/code/standards.html) for coding style,
84-
[PSR-4](http://www.php-fig.org/psr/psr-4/) for autoloading.
82+
Each project follows [PSR-1](https://www.php-fig.org/psr/psr-1/), [PSR-2](https://www.php-fig.org/psr/psr-2/)
83+
and [Symfony Coding Standards](https://symfony.com/doc/current/contributing/code/standards.html) for coding style,
84+
[PSR-4](https://www.php-fig.org/psr/psr-4/) for autoloading.
8585

86-
Please [install PHP Coding Standard Fixer](http://cs.sensiolabs.org/#installation)
86+
Please [install PHP Coding Standard Fixer](https://cs.symfony.com/#installation)
8787
and run this command before committing your modifications:
8888

8989
```bash
@@ -207,13 +207,13 @@ Your note can be put on one of these sections:
207207
* `Fixed` for any bug fixes.
208208
* `Security` to invite users to upgrade in case of vulnerabilities.
209209

210-
More information about the followed changelog format: [keepachangelog.com](http://keepachangelog.com/)
210+
More information about the followed changelog format: [keepachangelog.com](https://keepachangelog.com/)
211211

212212
#### Base branch
213213

214214
Before writing a PR, you have to check on which branch your changes SHOULD be based.
215215

216-
Each project follows [semver](http://semver.org/) convention for release management.
216+
Each project follows [semver](https://semver.org/) convention for release management.
217217

218218
Here is a short table resuming on which you have to start:
219219

@@ -329,7 +329,7 @@ If the deprecated thing is a service, you **MUST** specify it on the service def
329329
</service>
330330
```
331331

332-
More info: http://symfony.com/blog/new-in-symfony-2-8-deprecated-service-definitions
332+
More info: https://symfony.com/blog/new-in-symfony-2-8-deprecated-service-definitions
333333

334334
For everything else, not managed by the `@deprecated` tag,
335335
you **MUST** still trigger a deprecation message (and add a `NEXT_MAJOR` comment).

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ Check out the documentation on the [official website](https://docs.sonata-projec
2828

2929
## Support
3030

31-
For general support and questions, please use [StackOverflow](http://stackoverflow.com/questions/tagged/sonata).
31+
For general support and questions, please use [StackOverflow](https://stackoverflow.com/questions/tagged/sonata).
3232

3333
If you think you found a bug or you have a feature idea to propose, feel free to open an issue
3434
**after looking** at the [contributing guide](CONTRIBUTING.md).

0 commit comments

Comments
 (0)