no more warnings about absent seeds

Author: cieplypolar

apps/typegpu-docs/src/examples/tests/uniformity/constants.ts

@@ -1,5 +1,3 @@
-import type { PRNGKey } from './prngs.ts';
-
 export const gridSizes = [8, 16, 32, 64, 128, 256, 512, 1024];
 export const initialGridSize = gridSizes[4];
 export const samplesPerThread = [1, 8, 16, 64, 256, 1024, 131072, 262144];

apps/typegpu-docs/src/examples/tests/uniformity/index.ts

@@ -14,15 +14,13 @@ const presentationFormat = navigator.gpu.getPreferredCanvasFormat();
 const Config = d.struct({
   gridSize: d.f32,
   canvasRatio: d.f32,
-  useSeed2: d.u32,
   samplesPerThread: d.u32,
   takeAverage: d.u32,
 });
 
 const configUniform = root.createUniform(Config, {
   gridSize: c.initialGridSize,
   canvasRatio: canvas.width / canvas.height,
-  useSeed2: d.u32(prngs[initialPRNG].useSeed2),
   samplesPerThread: c.initialSamplesPerThread,
   takeAverage: d.u32(c.initialTakeAverage),
 });
@@ -38,7 +36,7 @@ const layouts = {
 
 const bindGroups = Object.fromEntries(
   c.gridSizes.map((size) => {
-    const texture = root['~unstable']
+    const texture = root
       .createTexture({ size: [size, size], format: 'r32float' })
       .$usage('storage', 'sampled');
     return [
@@ -68,10 +66,10 @@ const computeFn = (x: number, y: number) => {
   'use gpu';
   const gridSize = configUniform.$.gridSize;
 
-  if (configUniform.$.useSeed2 === 1) {
-    randf.seed2(d.vec2f(x, y) + 1);
-  } else {
+  if (!randomGeneratorSlot.$.seed2) {
     randf.seed(d.f32(x + 1) * gridSize + d.f32(y + 1));
+  } else {
+    randf.seed2(d.vec2f(x, y) + 1);
   }
 
   let i = d.u32(0);
@@ -120,7 +118,6 @@ export const controls = defineControls({
     options: prngKeys,
     onSelectChange: (value) => {
       prng = value;
-      configUniform.writePartial({ useSeed2: d.u32(prngs[value].useSeed2) });
       redraw();
     },
   },

apps/typegpu-docs/src/examples/tests/uniformity/prngs.ts

@@ -2,15 +2,14 @@ import { BPETER, LCG32, LCG64, XOROSHIRO64STARSTAR, type StatefulGenerator } fro
 
 interface PRNGOptions {
   name: string;
-  useSeed2: boolean;
   generator: StatefulGenerator;
 }
 
 export const prngs = {
-  bpeter: { name: 'bpeter (default)', useSeed2: true, generator: BPETER },
-  lcg32: { name: 'lcg32', useSeed2: false, generator: LCG32 },
-  lcg64: { name: 'lcg64', useSeed2: true, generator: LCG64 },
-  xoroshiro64: { name: 'xoroshiro64', useSeed2: true, generator: XOROSHIRO64STARSTAR },
+  bpeter: { name: 'bpeter (default)', generator: BPETER },
+  lcg32: { name: 'lcg32', generator: LCG32 },
+  lcg64: { name: 'lcg64', generator: LCG64 },
+  xoroshiro64: { name: 'xoroshiro64', generator: XOROSHIRO64STARSTAR },
 } as const satisfies Record<string, PRNGOptions>;
 
 export type PRNGKey = keyof typeof prngs;

packages/typegpu-noise/src/random.ts

@@ -9,8 +9,6 @@ const warnIfNotProvided = tgpu.comptime((seedFnName: keyof typeof randomGenerato
   if (!randomGeneratorSlot.$[seedFnName]) {
     console.warn(`Called \`randf.${seedFnName}\`, but it wasn't provided`);
   }
-
-  return undefined;
 });
 
 export const randSeed = tgpu.fn([d.f32])((seed) => {