Updating hello sdl example apps

Author: Julian Kast

android/hello_sdl_android/src/main/java/com/sdl/hellosdlandroid/SdlService.java

@@ -82,11 +82,6 @@ public class SdlService extends Service {
 	private SdlManager sdlManager = null;
 	private List<ChoiceCell> choiceCellList;
 
-	private ButtonName[] buttonNames = {ButtonName.PLAY_PAUSE, ButtonName.SEEKLEFT, ButtonName.SEEKRIGHT, ButtonName.AC_MAX, ButtonName.AC, ButtonName.RECIRCULATE,
-			ButtonName.FAN_UP, ButtonName.FAN_DOWN, ButtonName.TEMP_UP, ButtonName.FAN_DOWN, ButtonName.DEFROST_MAX, ButtonName.DEFROST_REAR, ButtonName.DEFROST,
-			ButtonName.UPPER_VENT, ButtonName.LOWER_VENT, ButtonName.VOLUME_UP, ButtonName.VOLUME_DOWN, ButtonName.EJECT, ButtonName.SOURCE, ButtonName.SHUFFLE, ButtonName.REPEAT};
-	private OnButtonListener onButtonListener;
-
 	@Override
 	public IBinder onBind(Intent intent) {
 		return null;
@@ -384,7 +379,11 @@ public void onComplete(boolean success) {
 	 * Attempts to Subscribe to all preset buttons
 	 */
 	private void subscribeToButtons() {
-		onButtonListener = new OnButtonListener() {
+		ButtonName[] buttonNames = {ButtonName.PLAY_PAUSE, ButtonName.SEEKLEFT, ButtonName.SEEKRIGHT, ButtonName.AC_MAX, ButtonName.AC, ButtonName.RECIRCULATE,
+				ButtonName.FAN_UP, ButtonName.FAN_DOWN, ButtonName.TEMP_UP, ButtonName.FAN_DOWN, ButtonName.DEFROST_MAX, ButtonName.DEFROST_REAR, ButtonName.DEFROST,
+				ButtonName.UPPER_VENT, ButtonName.LOWER_VENT, ButtonName.VOLUME_UP, ButtonName.VOLUME_DOWN, ButtonName.EJECT, ButtonName.SOURCE, ButtonName.SHUFFLE, ButtonName.REPEAT};
+
+		OnButtonListener onButtonListener = new OnButtonListener() {
 			@Override
 			public void onPress(ButtonName buttonName, OnButtonPress buttonPress) {
 				sdlManager.getScreenManager().setTextField1("Subscribed Button Named: " + buttonName + " was pressed");

hello_sdl_java/src/main/java/com/smartdevicelink/java/SdlService.java

@@ -77,18 +77,12 @@ public class SdlService {
 
     private static final String IMAGE_DIR =             "assets/images/";
 
-
-
     // variable to create and call functions of the SyncProxy
     private SdlManager sdlManager = null;
     private List<ChoiceCell> choiceCellList;
 
     private SdlServiceCallback callback;
 
-    private ButtonName[] buttonNames = {ButtonName.PLAY_PAUSE, ButtonName.SEEKLEFT, ButtonName.SEEKRIGHT, ButtonName.AC_MAX, ButtonName.AC, ButtonName.RECIRCULATE,
-            ButtonName.FAN_UP, ButtonName.FAN_DOWN, ButtonName.TEMP_UP, ButtonName.FAN_DOWN, ButtonName.DEFROST_MAX, ButtonName.DEFROST_REAR, ButtonName.DEFROST,
-            ButtonName.UPPER_VENT, ButtonName.LOWER_VENT, ButtonName.VOLUME_UP, ButtonName.VOLUME_DOWN, ButtonName.EJECT, ButtonName.SOURCE, ButtonName.SHUFFLE, ButtonName.REPEAT};    private OnButtonListener onButtonListener;
-
     public SdlService(BaseTransportConfig config, SdlServiceCallback callback){
         this.callback = callback;
         buildSdlManager(config);
@@ -334,7 +328,11 @@ public void onComplete(boolean success) {
      * Attempts to Subscribe to all preset buttons
      */
     private void subscribeToButtons() {
-        onButtonListener = new OnButtonListener() {
+        ButtonName[] buttonNames = {ButtonName.PLAY_PAUSE, ButtonName.SEEKLEFT, ButtonName.SEEKRIGHT, ButtonName.AC_MAX, ButtonName.AC, ButtonName.RECIRCULATE,
+                ButtonName.FAN_UP, ButtonName.FAN_DOWN, ButtonName.TEMP_UP, ButtonName.FAN_DOWN, ButtonName.DEFROST_MAX, ButtonName.DEFROST_REAR, ButtonName.DEFROST,
+                ButtonName.UPPER_VENT, ButtonName.LOWER_VENT, ButtonName.VOLUME_UP, ButtonName.VOLUME_DOWN, ButtonName.EJECT, ButtonName.SOURCE, ButtonName.SHUFFLE, ButtonName.REPEAT};
+
+       OnButtonListener onButtonListener = new OnButtonListener() {
             @Override
             public void onPress(ButtonName buttonName, OnButtonPress buttonPress) {
                 sdlManager.getScreenManager().setTextField1("Subscribed Button Named: " + buttonName + " was pressed");
@@ -356,15 +354,6 @@ public void onError(String info) {
         }
     }
 
-    /**
-     * Attempts to Unsubscribe to all preset Buttons
-     */
-    private void unsubscribeToPresetButtons() {
-        for (ButtonName buttonName : buttonNames) {
-            sdlManager.getScreenManager().removeButtonListener(buttonName, onButtonListener);
-        }
-    }
-
     /**
      * Will show a sample test message on screen as well as speak a sample test message
      */