Skip to content

Commit b5eeb93

Browse files
Update methods names
1 parent 462249a commit b5eeb93

1 file changed

Lines changed: 11 additions & 11 deletions

File tree

android/sdl_android/src/androidTest/java/com/smartdevicelink/test/rpc/RPCGenericTests.java

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -428,19 +428,10 @@ private Map<String, RPC> getRPCsMap(String fileName, boolean includeMandatoryPar
428428
return rpcParamsMap;
429429
}
430430

431-
private boolean isDeprecated (AnnotatedElement element) {
432-
for (Annotation annotation : element.getDeclaredAnnotations()) {
433-
if (annotation.annotationType().getSimpleName().equalsIgnoreCase("deprecated")) {
434-
return true;
435-
}
436-
}
437-
return false;
438-
}
439-
440431
// This method makes sure that for every function and struct RPC, there is a constructor that has all the mandatory params
441432
// It also checks if there are function and struct RPCs in the XML file that don't exist in the code
442433
@Test
443-
public void testMandatoryParamsMatch() {
434+
public void testConstructorWithMandatoryParamsExist() {
444435
// List of RPC names that don't have a constructor that has all mandatory params
445436
List<String> rpcsWithInvalidConstructor = new ArrayList<>();
446437

@@ -505,6 +496,15 @@ else if (!paramFullType.contains(">")) {
505496
assertTrue("The following RPCs don't have a constructor that has all the mandatory params: " + rpcsWithInvalidConstructor, rpcsWithInvalidConstructor.isEmpty());
506497
}
507498

499+
private boolean isDeprecated (AnnotatedElement element) {
500+
for (Annotation annotation : element.getDeclaredAnnotations()) {
501+
if (annotation.annotationType().getSimpleName().equalsIgnoreCase("deprecated")) {
502+
return true;
503+
}
504+
}
505+
return false;
506+
}
507+
508508
// This method returns the correct java reflection method in a specific class
509509
private Method getMethod(Class aClass, Parameter parameter, String methodName, boolean isGetter) throws NoSuchMethodException {
510510
Method method = null;
@@ -579,7 +579,7 @@ private Class<?> findJavaTypeForParam(String type, boolean isArray) {
579579

580580
// This method makes sure that for every function and struct RPC, the constructor that has the mandatory params is setting the values correctly
581581
@Test
582-
public void testMandatoryParamsValues() {
582+
public void testConstructorWithMandatoryParamsValues() {
583583
// List of RPC names that have a constructor which is not settings the values for the mandatory params correctly
584584
List<String> rpcsWithInvalidConstructor = new ArrayList<>();
585585

0 commit comments

Comments
 (0)