Fix deleting voiceCommand logic

Julian Kast · Julian Kast · commit a7c391d1c107 · 2021-05-25T12:52:21.000-04:00
diff --git a/base/src/main/java/com/smartdevicelink/managers/screen/menu/BaseVoiceCommandManager.java b/base/src/main/java/com/smartdevicelink/managers/screen/menu/BaseVoiceCommandManager.java
@@ -145,15 +145,14 @@ public void setVoiceCommands(List<VoiceCommand> voiceCommands) {
 
         List<VoiceCommand> validatedVoiceCommands = removeEmptyVoiceCommands(this.voiceCommands);
 
-        if (validatedVoiceCommands.size() == 0) {
+        if (validatedVoiceCommands.size() == 0 && voiceCommands.size() > 0) {
             DebugTool.logError(TAG, "New voice commands are invalid, skipping...");
             return;
         }
 
         if (!isVoiceCommandsUnique(validatedVoiceCommands)) {
             DebugTool.logError(TAG, "Not all voice command strings are unique across all voice commands. Voice commands will not be set.");
             return;
-
         }
 
         updateIdsOnVoiceCommands(this.voiceCommands);

Original file line number	Diff line number	Diff line change
`@@ -145,15 +145,14 @@ public void setVoiceCommands(List<VoiceCommand> voiceCommands) {`
`145`	`145`
`146`	`146`	`List<VoiceCommand> validatedVoiceCommands = removeEmptyVoiceCommands(this.voiceCommands);`
`147`	`147`
`148`		`- if (validatedVoiceCommands.size() == 0) {`
	`148`	`+ if (validatedVoiceCommands.size() == 0 && voiceCommands.size() > 0) {`
`149`	`149`	`DebugTool.logError(TAG, "New voice commands are invalid, skipping...");`
`150`	`150`	`return;`
`151`	`151`	`}`
`152`	`152`
`153`	`153`	`if (!isVoiceCommandsUnique(validatedVoiceCommands)) {`
`154`	`154`	`DebugTool.logError(TAG, "Not all voice command strings are unique across all voice commands. Voice commands will not be set.");`
`155`	`155`	`return;`
`156`		`-`
`157`	`156`	`}`
`158`	`157`
`159`	`158`	`updateIdsOnVoiceCommands(this.voiceCommands);`