Skip to content

Commit 99d5a47

Browse files
committed
Remove unused return value from tryVideoStream
1 parent ecb3b38 commit 99d5a47

1 file changed

Lines changed: 4 additions & 13 deletions

File tree

android/sdl_android/src/main/java/com/smartdevicelink/managers/lifecycle/LifecycleManager.java

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -238,18 +238,18 @@ void startVideoService(boolean isEncrypted, VideoStreamingParameters parameters)
238238
* mode (i.e. without any negotiation) then an instance of VideoStreamingParams is
239239
* returned. If the service was not opened then null is returned.
240240
*/
241-
private VideoStreamingParameters tryStartVideoStream(boolean isEncrypted, VideoStreamingParameters parameters) {
241+
private void tryStartVideoStream(boolean isEncrypted, VideoStreamingParameters parameters) {
242242
if (session == null) {
243243
DebugTool.logWarning("SdlSession is not created yet.");
244-
return null;
244+
return;
245245
}
246246
if (getProtocolVersion() != null && getProtocolVersion().getMajor() >= 5 && !systemCapabilityManager.isCapabilitySupported(SystemCapabilityType.VIDEO_STREAMING)) {
247247
DebugTool.logWarning("Module doesn't support video streaming.");
248-
return null;
248+
return;
249249
}
250250
if (parameters == null) {
251251
DebugTool.logWarning("Video parameters were not supplied.");
252-
return null;
252+
return;
253253
}
254254

255255

@@ -264,15 +264,6 @@ private VideoStreamingParameters tryStartVideoStream(boolean isEncrypted, VideoS
264264
session.startService(SessionType.NAV, session.getSessionId(), isEncrypted);
265265

266266
}
267-
268-
if (videoServiceStartResponse) {
269-
if (getProtocolVersion() != null && getProtocolVersion().getMajor() < 5) { //Versions 1-4 do not support streaming parameter negotiations
270-
session.setAcceptedVideoParams(parameters);
271-
}
272-
return session.getAcceptedVideoParams();
273-
}
274-
275-
return null;
276267
}
277268

278269
private void addVideoServiceListener() {

0 commit comments

Comments
 (0)