Skip to content

Commit 6132759

Browse files
Undo some deprecations
1 parent da60327 commit 6132759

3 files changed

Lines changed: 11 additions & 30 deletions

File tree

android/sdl_android/src/androidTest/java/com/smartdevicelink/test/rpc/RPCGenericTests.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,8 @@ private Map<String, List<Parameter>> getRPCParamsMap(String fileName, boolean in
181181
paramName = "sdlMsgVersion";
182182
} else if (paramName.equals("hmiPermissions")){
183183
paramName = "HMIPermissions";
184+
} else if (paramName.equals("resolution")){
185+
paramName = "imageResolution";
184186
}
185187

186188
setterMethodName = "set" + paramName.substring(0, 1).toUpperCase() + paramName.substring(1);
@@ -211,8 +213,6 @@ private Map<String, List<Parameter>> getRPCParamsMap(String fileName, boolean in
211213
setterMethodName = "setInteractionFunctionID";
212214
} else if (rpcName.equals("NavigationCapability") && setterMethodName.equals("setGetWayPointsEnabled")) {
213215
setterMethodName = "setWayPointsEnabled";
214-
} else if (rpcName.equals("HMICapabilities")) {
215-
setterMethodName += "Available";
216216
} else if (setterMethodName.equals("setFuelLevel_State")) {
217217
setterMethodName = "setFuelLevelState";
218218
} else if (rpcName.equals("SystemCapability") && !setterMethodName.equals("setSystemCapabilityType")) {
@@ -286,6 +286,10 @@ private Map<String, List<Parameter>> getRPCParamsMap(String fileName, boolean in
286286
setterMethodName = "setTPMS";
287287
} else if (rpcName.equals("VehicleDataResult") && setterMethodName.equals("setOemCustomDataType")) {
288288
setterMethodName = "setOEMCustomVehicleDataType";
289+
} else if (rpcName.equals("HMICapabilities") && setterMethodName.equals("setDisplays")) {
290+
setterMethodName = "setDisplaysCapabilityAvailable";
291+
} else if (rpcName.equals("HMICapabilities")) {
292+
setterMethodName += "Available";
289293
}
290294

291295
// -------------------------------------------------------------------------------------------------------------

base/src/main/java/com/smartdevicelink/proxy/rpc/HMICapabilities.java

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -128,29 +128,18 @@ public HMICapabilities setAppServicesAvailable( Boolean available) {
128128
return this;
129129
}
130130

131-
@Deprecated
132131
public boolean isDisplaysCapabilityAvailable(){
133-
return isDisplaysAvailable();
134-
}
135-
136-
@Deprecated
137-
public HMICapabilities setDisplaysCapabilityAvailable( Boolean available) {
138-
setValue(KEY_DISPLAYS, available);
139-
return this;
140-
}
141-
142-
public boolean isDisplaysAvailable() {
143132
Object available = getValue(KEY_DISPLAYS);
144133
if (available == null) {
145134
return false;
146135
}
147136
return (Boolean) available;
148137
}
149138

150-
public HMICapabilities setDisplaysAvailable(Boolean available) {
151-
setValue(KEY_DISPLAYS, available);
152-
return this;
153-
}
139+
public HMICapabilities setDisplaysCapabilityAvailable( Boolean available) {
140+
setValue(KEY_DISPLAYS, available);
141+
return this;
142+
}
154143

155144
public boolean isSeatLocationAvailable(){
156145
Object available = getValue(KEY_SEAT_LOCATION);

base/src/main/java/com/smartdevicelink/proxy/rpc/ScreenParams.java

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -102,25 +102,13 @@ public ScreenParams(@NonNull ImageResolution resolution) {
102102
}
103103

104104
@SuppressWarnings("unchecked")
105-
@Deprecated
106105
public ImageResolution getImageResolution() {
107106
return (ImageResolution) getObject(ImageResolution.class, KEY_RESOLUTION);
108-
}
109-
@Deprecated
107+
}
110108
public ScreenParams setImageResolution(@NonNull ImageResolution resolution) {
111109
setValue(KEY_RESOLUTION, resolution);
112110
return this;
113111
}
114-
115-
public ImageResolution getResolution() {
116-
return (ImageResolution) getObject(ImageResolution.class, KEY_RESOLUTION);
117-
}
118-
119-
public ScreenParams setResolution(@NonNull ImageResolution resolution) {
120-
setValue(KEY_RESOLUTION, resolution);
121-
return this;
122-
}
123-
124112
@SuppressWarnings("unchecked")
125113
public TouchEventCapabilities getTouchEventAvailable() {
126114
return (TouchEventCapabilities) getObject(TouchEventCapabilities.class, KEY_TOUCH_EVENT_AVAILABLE);

0 commit comments

Comments
 (0)