Move TransportRecord parcel constructor to Android

Author: bilal-alsharifi

android/sdl_android/src/main/java/com/smartdevicelink/transport/utl/TransportRecord.java

@@ -12,7 +12,16 @@ public TransportRecord(TransportType transportType, String address) {
     }
 
     public TransportRecord(Parcel p) {
-        super(p);
+        if (p.readInt() == 1) { //We should have a transport type attached
+            String transportName = p.readString();
+            if(transportName != null){
+                this.type = TransportType.valueOf(transportName);
+            }
+        }
+
+        if (p.readInt() == 1) { //We should have a transport address attached
+            address = p.readString();
+        }
     }
 
     @Override

base/src/main/java/com/smartdevicelink/transport/utl/BaseTransportRecord.java

@@ -32,14 +32,15 @@
 
 package com.smartdevicelink.transport.utl;
 
-import android.os.Parcel;
 import com.smartdevicelink.transport.enums.TransportType;
 
 class BaseTransportRecord{
 
     protected TransportType type;
     protected String address;
 
+    BaseTransportRecord(){}
+
     BaseTransportRecord(TransportType transportType, String address){
         this.type = transportType;
         this.address = address;
@@ -78,17 +79,4 @@ public String toString(){
         builder.append(address);
         return builder.toString();
     }
-
-    BaseTransportRecord(Parcel p) {
-        if (p.readInt() == 1) { //We should have a transport type attached
-            String transportName = p.readString();
-            if(transportName != null){
-                this.type = TransportType.valueOf(transportName);
-            }
-        }
-
-        if (p.readInt() == 1) { //We should have a transport address attached
-            address = p.readString();
-        }
-    }
 }

javaSE/src/main/java/com/smartdevicelink/transport/utl/TransportRecord.java

@@ -42,9 +42,7 @@ public TransportRecord(TransportType transportType, String address) {
     }
 
     @Deprecated
-    public TransportRecord(Parcel p) {
-        super(p);
-    }
+    public TransportRecord(Parcel p) {}
 
     @Deprecated
     public int describeContents() {