Put the onProxyClosed() logic in BaseSdlManager

Author: bilal-alsharifi

android/sdl_android/src/main/java/com/smartdevicelink/managers/SdlManager.java

@@ -211,14 +211,6 @@ public void run() {
         }
     }
 
-    @Override
-    void onProxyClosed(SdlDisconnectedReason reason) {
-        Log.i(TAG, "Proxy is closed.");
-        if (reason == null || !reason.equals(SdlDisconnectedReason.LANGUAGE_CHANGE)) {
-            dispose();
-        }
-    }
-
     /**
      * Dispose SdlManager and clean its resources
      * <strong>Note: new instance of SdlManager should be created on every connection. SdlManager cannot be reused after getting disposed.</strong>

base/src/main/java/com/smartdevicelink/managers/BaseSdlManager.java

@@ -142,7 +142,10 @@ public void onServiceEnded(SessionType sessionType) {
 
         @Override
         public void onProxyClosed(LifecycleManager lifeCycleManager, String info, Exception e, SdlDisconnectedReason reason) {
-            BaseSdlManager.this.onProxyClosed(reason);
+            Log.i(TAG, "Proxy is closed.");
+            if (reason == null || !reason.equals(SdlDisconnectedReason.LANGUAGE_CHANGE)) {
+                dispose();
+            }
         }
 
         @Override
@@ -165,8 +168,6 @@ public synchronized void onComplete(boolean success) {
     // ABSTRACT METHODS
     abstract void retryChangeRegistration();
 
-    abstract void onProxyClosed(SdlDisconnectedReason reason);
-
     abstract void checkState();
 
     abstract void initialize();

base/src/main/java/com/smartdevicelink/managers/lifecycle/BaseLifecycleManager.java

@@ -1496,8 +1496,7 @@ void onProtocolSessionStarted(SessionType sessionType) {
         }
     }
 
-    void cycleProxy(SdlDisconnectedReason disconnectedReason) {
-    }
+    abstract void cycleProxy(SdlDisconnectedReason disconnectedReason);
 
     void onTransportDisconnected(String info, boolean availablePrimary, BaseTransportConfig transportConfig) {
     }

javaSE/src/main/java/com/smartdevicelink/managers/SdlManager.java

@@ -141,14 +141,6 @@ void retryChangeRegistration() {
         // Do nothing
     }
 
-    @Override
-    void onProxyClosed(SdlDisconnectedReason reason) {
-        Log.i(TAG, "Proxy is closed.");
-        if (managerListener != null) {
-            managerListener.onDestroy(SdlManager.this);
-        }
-    }
-
     @Override
     public void dispose() {
         if (this.permissionManager != null) {

javaSE/src/main/java/com/smartdevicelink/managers/lifecycle/LifecycleManager.java

@@ -35,6 +35,8 @@
 import android.support.annotation.RestrictTo;
 
 import com.smartdevicelink.SdlConnection.SdlSession;
+import com.smartdevicelink.exception.SdlException;
+import com.smartdevicelink.proxy.rpc.enums.SdlDisconnectedReason;
 import com.smartdevicelink.transport.BaseTransportConfig;
 
 /**
@@ -53,11 +55,25 @@ void initializeProxy() {
         this.session = new SdlSession(sdlConnectionListener, _transportConfig);
     }
 
+    @Override
+    void cycleProxy(SdlDisconnectedReason disconnectedReason) {
+        if (session != null) {
+            if (session.getIsConnected()) {
+                session.close();
+            }
+            try {
+                session.startSession();
+            } catch (SdlException e) {
+                e.printStackTrace();
+            }
+        }
+    }
+
     @Override
     void onTransportDisconnected(String info, boolean availablePrimary, BaseTransportConfig transportConfig) {
         super.onTransportDisconnected(info, availablePrimary, transportConfig);
         if (!availablePrimary) {
-            onClose(info, null);
+            onClose(info, null, null);
         }
     }
 }