Skip to content

Commit 1f6662f

Browse files
authored
Merge pull request #1291 from smartdevicelink/feature/deprecate_device_os
Deprecate DeviceInfo.DEVICE_OS
2 parents eb7a74d + dd63e1b commit 1f6662f

3 files changed

Lines changed: 3 additions & 2 deletions

File tree

android/sdl_android/src/main/java/com/smartdevicelink/proxy/RPCRequestFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1022,7 +1022,7 @@ public static DeviceInfo BuildDeviceInfo(String carrierName)
10221022
{
10231023
DeviceInfo msg = new DeviceInfo();
10241024
msg.setHardware(android.os.Build.MODEL);
1025-
msg.setOs(DeviceInfo.DEVICE_OS);
1025+
msg.setOs("Android");
10261026
msg.setOsVersion(Build.VERSION.RELEASE);
10271027
msg.setCarrier(carrierName);
10281028
return msg;

android/sdl_android/src/main/java/com/smartdevicelink/proxy/SdlProxyBase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6721,7 +6721,7 @@ protected void registerAppInterfacePrivate(
67216721

67226722
DeviceInfo deviceInfo = new DeviceInfo();
67236723
deviceInfo.setHardware(android.os.Build.MODEL);
6724-
deviceInfo.setOs(DeviceInfo.DEVICE_OS);
6724+
deviceInfo.setOs("Android");
67256725
deviceInfo.setOsVersion(Build.VERSION.RELEASE);
67266726
deviceInfo.setCarrier(carrierName);
67276727

base/src/main/java/com/smartdevicelink/proxy/rpc/DeviceInfo.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@ public class DeviceInfo extends RPCStruct{
108108
public static final String KEY_OS_VERSION = "osVersion";
109109
public static final String KEY_CARRIER = "carrier";
110110
public static final String KEY_MAX_NUMBER_RFCOMM_PORTS = "maxNumberRFCOMMPorts";
111+
@Deprecated
111112
public static final String DEVICE_OS = "Android";
112113

113114
public DeviceInfo() { }

0 commit comments

Comments
 (0)