Skip to content

Commit 1f4cfcc

Browse files
HeniganHenigan
authored andcommitted
Code Review Fixes
1 parent a9c8fd8 commit 1f4cfcc

4 files changed

Lines changed: 12 additions & 5 deletions

File tree

base/src/main/java/com/smartdevicelink/protocol/SdlPacketFactory.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@
3535

3636
import com.smartdevicelink.protocol.enums.ControlFrameTags;
3737
import com.smartdevicelink.protocol.enums.FrameDataControlFrameType;
38-
import com.smartdevicelink.protocol.enums.QueryID;
39-
import com.smartdevicelink.protocol.enums.QueryType;
4038
import com.smartdevicelink.protocol.enums.SessionType;
4139
import com.smartdevicelink.util.BitConverter;
4240

base/src/main/java/com/smartdevicelink/protocol/enums/QueryErrorCode.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
11
package com.smartdevicelink.protocol.enums;
22

3+
import androidx.annotation.RestrictTo;
4+
35
import com.smartdevicelink.util.ByteEnumer;
46

57
import java.util.Vector;
68

9+
@RestrictTo(RestrictTo.Scope.LIBRARY)
710
public class QueryErrorCode extends ByteEnumer {
811

912
private static final Vector<QueryErrorCode> theList = new Vector<>();

base/src/main/java/com/smartdevicelink/protocol/enums/QueryID.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,15 @@
11
package com.smartdevicelink.protocol.enums;
22

3+
import androidx.annotation.RestrictTo;
4+
35
import com.smartdevicelink.util.BitConverter;
46

57
import java.util.Arrays;
68
import java.util.Enumeration;
79
import java.util.Objects;
810
import java.util.Vector;
911

12+
@RestrictTo(RestrictTo.Scope.LIBRARY)
1013
public class QueryID {
1114

1215
private static final Vector<QueryID> theList = new Vector<>();
@@ -15,9 +18,9 @@ public static Vector<QueryID> getList() {
1518
return theList;
1619
}
1720

18-
private static final byte[] sendHandshakeDataByteArray= {(byte) 0x00, (byte) 0x00, (byte) 0x01};
19-
private static final byte[] sendInternalErrorByteArray= {(byte) 0x00, (byte) 0x00, (byte) 0x02};
20-
private static final byte[] invalidQueryIdByteArray= {(byte) 0xFF, (byte) 0xFF, (byte) 0xFF};
21+
private static final byte[] sendHandshakeDataByteArray = {(byte) 0x00, (byte) 0x00, (byte) 0x01};
22+
private static final byte[] sendInternalErrorByteArray = {(byte) 0x00, (byte) 0x00, (byte) 0x02};
23+
private static final byte[] invalidQueryIdByteArray = {(byte) 0xFF, (byte) 0xFF, (byte) 0xFF};
2124
public final static QueryID SEND_HANDSHAKE_DATA = new QueryID(sendHandshakeDataByteArray, "SEND_HANDSHAKE_DATA");
2225
public final static QueryID SEND_INTERNAL_ERROR = new QueryID(sendInternalErrorByteArray, "SEND_INTERNAL_ERROR");
2326
public final static QueryID INVALID_QUERY_ID = new QueryID(invalidQueryIdByteArray, "INVALID_QUERY_ID");

base/src/main/java/com/smartdevicelink/protocol/enums/QueryType.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
11
package com.smartdevicelink.protocol.enums;
22

3+
import androidx.annotation.RestrictTo;
4+
35
import com.smartdevicelink.util.ByteEnumer;
46

57
import java.util.Vector;
68

9+
@RestrictTo(RestrictTo.Scope.LIBRARY)
710
public class QueryType extends ByteEnumer {
811

912
private static final Vector<QueryType> theList = new Vector<>();

0 commit comments

Comments
 (0)