Skip to content

Commit 11fb324

Browse files
committed
PR feedback fixes
1 parent b232716 commit 11fb324

3 files changed

Lines changed: 7 additions & 9 deletions

File tree

android/sdl_android/src/androidTest/java/com/smartdevicelink/test/rpc/notifications/OnAppCapabilityUpdatedTests.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,7 @@ protected JSONObject getExpectedParameters(int sdlVersion) {
4242

4343
try {
4444
result.put(OnAppCapabilityUpdated.KEY_APP_CAPABILITY, TestValues.GENERAL_APPCAPABILITY.serializeJSON());
45-
}
46-
catch (JSONException e) {
45+
} catch (JSONException e) {
4746
fail(TestValues.JSON_FAIL);
4847
}
4948

android/sdl_android/src/main/java/com/smartdevicelink/encoder/VirtualDisplayEncoder.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -228,8 +228,7 @@ public void shutDown() {
228228
mCaptureThread.stopAsync();
229229
try {
230230
mCaptureThread.join();
231-
}
232-
catch (InterruptedException e) {}
231+
} catch (InterruptedException e) {}
233232
mCaptureThread = null;
234233
}
235234
if (encoderThread != null) {

base/src/main/java/com/smartdevicelink/transport/SdlPsm.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -133,11 +133,11 @@ private int transitionOnInput(byte rawByte, int state) {
133133
//Log.trace(TAG,"Frame Info: " + controlFrameInfo);
134134
switch (frameType) {
135135
case SdlPacket.FRAME_TYPE_CONTROL:
136-
/*if(frameInfo<FRAME_INFO_HEART_BEAT
137-
|| (frameInfo>FRAME_INFO_END_SERVICE_ACK
138-
&& (frameInfo!=FRAME_INFO_SERVICE_DATA_ACK || frameInfo!=FRAME_INFO_HEART_BEAT_ACK))){
139-
return ERROR_STATE;
140-
}*/ //Although some bits are reserved...whatever
136+
/*if(frameInfo<FRAME_INFO_HEART_BEAT
137+
|| (frameInfo>FRAME_INFO_END_SERVICE_ACK
138+
&& (frameInfo!=FRAME_INFO_SERVICE_DATA_ACK || frameInfo!=FRAME_INFO_HEART_BEAT_ACK))){
139+
return ERROR_STATE;
140+
}*/ //Although some bits are reserved...whatever
141141
break;
142142
case SdlPacket.FRAME_TYPE_SINGLE: //Fall through since they are both the same
143143
case SdlPacket.FRAME_TYPE_FIRST:

0 commit comments

Comments
 (0)