Skip to content

Commit 0f04566

Browse files
Remove duplicate code from PreloadChoicesOperation
1 parent 9761aab commit 0f04566

2 files changed

Lines changed: 18 additions & 16 deletions

File tree

base/src/main/java/com/smartdevicelink/managers/screen/BaseTextAndGraphicManager.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -785,22 +785,22 @@ private boolean templateSupportsImageField(ImageFieldName name) {
785785
* @return true if mediaTrackTextField should be updated, false if not
786786
*/
787787
private boolean shouldUpdateMediaTrackField() {
788-
return shouldUpdateField(TextFieldName.mediaTrack);
788+
return templateSupportsTextField(TextFieldName.mediaTrack);
789789
}
790790

791791
/**
792792
* Check to see if title should be updated
793793
* @return true if title should be updated, false if not
794794
*/
795795
private boolean shouldUpdateTitleField() {
796-
return shouldUpdateField(TextFieldName.templateTitle);
796+
return templateSupportsTextField(TextFieldName.templateTitle);
797797
}
798798

799799
/**
800800
* Check to see if field should be updated
801801
* @return true if field should be updated, false if not
802802
*/
803-
private boolean shouldUpdateField(TextFieldName name) {
803+
private boolean templateSupportsTextField(TextFieldName name) {
804804
return (defaultMainWindowCapability != null && defaultMainWindowCapability.getTextFields() != null)
805805
? ManagerUtility.WindowCapabilityUtility.hasTextFieldOfName(defaultMainWindowCapability, name)
806806
: true;

base/src/main/java/com/smartdevicelink/managers/screen/choiceset/PreloadChoicesOperation.java

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -234,32 +234,34 @@ boolean shouldSendChoiceText() {
234234
if (this.displayName != null && this.displayName.equals(DisplayType.GEN3_8_INCH)){
235235
return true;
236236
}
237-
return (defaultMainWindowCapability != null && defaultMainWindowCapability.getTextFields() != null)
238-
? ManagerUtility.WindowCapabilityUtility.hasTextFieldOfName(defaultMainWindowCapability, TextFieldName.menuName)
239-
: true;
237+
return templateSupportsTextField(TextFieldName.menuName);
240238
}
241239

242240
boolean shouldSendChoiceSecondaryText() {
243-
return (defaultMainWindowCapability != null && defaultMainWindowCapability.getTextFields() != null)
244-
? ManagerUtility.WindowCapabilityUtility.hasTextFieldOfName(defaultMainWindowCapability, TextFieldName.secondaryText)
245-
: true;
241+
return templateSupportsTextField(TextFieldName.secondaryText);
246242
}
247243

248244
boolean shouldSendChoiceTertiaryText() {
249-
return (defaultMainWindowCapability != null && defaultMainWindowCapability.getTextFields() != null)
250-
? ManagerUtility.WindowCapabilityUtility.hasTextFieldOfName(defaultMainWindowCapability, TextFieldName.tertiaryText)
251-
: true;
245+
return templateSupportsTextField(TextFieldName.tertiaryText);
252246
}
253247

254248
boolean shouldSendChoicePrimaryImage() {
255-
return (defaultMainWindowCapability != null && defaultMainWindowCapability.getImageFields() != null)
256-
? ManagerUtility.WindowCapabilityUtility.hasImageFieldOfName(defaultMainWindowCapability, ImageFieldName.choiceImage)
257-
: true;
249+
return templateSupportsImageField(ImageFieldName.choiceImage);
258250
}
259251

260252
boolean shouldSendChoiceSecondaryImage() {
253+
return templateSupportsImageField(ImageFieldName.choiceSecondaryImage);
254+
}
255+
256+
boolean templateSupportsTextField(TextFieldName name) {
257+
return (defaultMainWindowCapability != null && defaultMainWindowCapability.getTextFields() != null)
258+
? ManagerUtility.WindowCapabilityUtility.hasTextFieldOfName(defaultMainWindowCapability, name)
259+
: true;
260+
}
261+
262+
boolean templateSupportsImageField(ImageFieldName name) {
261263
return (defaultMainWindowCapability != null && defaultMainWindowCapability.getImageFields() != null)
262-
? ManagerUtility.WindowCapabilityUtility.hasImageFieldOfName(defaultMainWindowCapability, ImageFieldName.choiceSecondaryImage)
264+
? ManagerUtility.WindowCapabilityUtility.hasImageFieldOfName(defaultMainWindowCapability, name)
263265
: true;
264266
}
265267

0 commit comments

Comments
 (0)