Skip to content

Commit 0abaa2b

Browse files
committed
Revert "Pass NotificationListeners OnProxyClose"
This reverts commit ee38da7.
1 parent ee38da7 commit 0abaa2b

2 files changed

Lines changed: 2 additions & 17 deletions

File tree

base/src/main/java/com/smartdevicelink/managers/BaseSdlManager.java

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@
7171
import org.json.JSONException;
7272

7373
import java.util.ArrayList;
74-
import java.util.HashMap;
7574
import java.util.List;
7675
import java.util.Map;
7776
import java.util.Queue;
@@ -131,15 +130,6 @@ public void onProxyConnected(LifecycleManager lifeCycleManager) {
131130
}
132131
}
133132

134-
@Override
135-
@Deprecated
136-
public void onProxyClosed(LifecycleManager lifeCycleManager, String info, Exception e, SdlDisconnectedReason reason) {
137-
Log.i(TAG, "Proxy is closed.");
138-
if (reason == null || !reason.equals(SdlDisconnectedReason.LANGUAGE_CHANGE)) {
139-
dispose();
140-
}
141-
}
142-
143133
@Override
144134
public void onServiceStarted(SessionType sessionType) {
145135

@@ -151,12 +141,11 @@ public void onServiceEnded(SessionType sessionType) {
151141
}
152142

153143
@Override
154-
public void onProxyClosed(LifecycleManager lifeCycleManager, String info, Exception e, SdlDisconnectedReason reason, HashMap rpcNotificationListeners) {
144+
public void onProxyClosed(LifecycleManager lifeCycleManager, String info, Exception e, SdlDisconnectedReason reason) {
155145
Log.i(TAG, "Proxy is closed.");
156146
if (reason == null || !reason.equals(SdlDisconnectedReason.LANGUAGE_CHANGE)) {
157147
dispose();
158148
}
159-
onRPCNotificationListeners = rpcNotificationListeners;
160149
}
161150

162151
@Override
@@ -322,7 +311,6 @@ void handleQueuedNotifications() {
322311
//Set variables to null that are no longer needed
323312
queuedNotifications = null;
324313
queuedNotificationListener = null;
325-
onRPCNotificationListeners = null;
326314
}
327315
}
328316

base/src/main/java/com/smartdevicelink/managers/lifecycle/BaseLifecycleManager.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,7 @@ public OnHMIStatus getCurrentHMIStatus() {
329329
void onClose(String info, Exception e, SdlDisconnectedReason reason) {
330330
Log.i(TAG, "onClose");
331331
if (lifecycleListener != null) {
332-
lifecycleListener.onProxyClosed((LifecycleManager) this, info, e, reason, rpcNotificationListeners);
332+
lifecycleListener.onProxyClosed((LifecycleManager) this, info, e, reason);
333333
}
334334
}
335335

@@ -1155,11 +1155,8 @@ public void startRPCEncryption() {
11551155
public interface LifecycleListener {
11561156
void onProxyConnected(LifecycleManager lifeCycleManager);
11571157

1158-
@Deprecated
11591158
void onProxyClosed(LifecycleManager lifeCycleManager, String info, Exception e, SdlDisconnectedReason reason);
11601159

1161-
void onProxyClosed(LifecycleManager lifeCycleManager, String info, Exception e, SdlDisconnectedReason reason, HashMap rpcNotificationListeners);
1162-
11631160
void onServiceStarted(SessionType sessionType);
11641161

11651162
void onServiceEnded(SessionType sessionType);

0 commit comments

Comments
 (0)