Skip to content

Commit 057b7b8

Browse files
author
Julian Kast
committed
Minor change to logic of onError to be more efficient
1 parent ca37f20 commit 057b7b8

1 file changed

Lines changed: 7 additions & 6 deletions

File tree

base/src/main/java/com/smartdevicelink/managers/file/BaseFileManager.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -282,16 +282,17 @@ public void onFinished() {
282282

283283
@Override
284284
public void onError(int correlationId, Result resultCode, String info) {
285-
if (requestMap != null && requestMap.get(correlationId) != null) {
285+
final RPCRequest request = requestMap.get(correlationId);
286+
if (request != null) {
286287
if (!deletionOperation) {
287-
if (shouldReUploadFile(((PutFile) requestMap.get(correlationId)).getSdlFileName(), ((PutFile) requestMap.get(correlationId)).getFileType())) {
288-
requestMap.get(correlationId).setOnRPCResponseListener(null);
289-
requestsToResend.add(requestMap.get(correlationId));
288+
if (shouldReUploadFile(((PutFile) request).getSdlFileName(), ((PutFile) request).getFileType())) {
289+
request.setOnRPCResponseListener(null);
290+
requestsToResend.add(request);
290291
} else {
291-
errors.put(((PutFile) requestMap.get(correlationId)).getSdlFileName(), buildErrorString(resultCode, info));
292+
errors.put(((PutFile) request).getSdlFileName(), buildErrorString(resultCode, info));
292293
}
293294
} else {
294-
errors.put(((DeleteFile) requestMap.get(correlationId)).getSdlFileName(), buildErrorString(resultCode, info));
295+
errors.put(((DeleteFile) request).getSdlFileName(), buildErrorString(resultCode, info));
295296
}
296297
}
297298
}

0 commit comments

Comments
 (0)