Add duplicate name check to setStates()

Add testAssignSameNameStateListToSoftButtonObject() to test the new behavior

Author: noah-livio

android/sdl_android/src/androidTest/java/com/smartdevicelink/managers/screen/SoftButtonManagerTests.java

@@ -461,4 +461,26 @@ public void testAssignNonEmptyStateListToSoftButtonObject() {
 
         assertEquals(stateList2, softButtonObject.getStates());
     }
+
+    /**
+     * Test assigning a state list with states that have the same name to existing SoftButtonObject
+     */
+    @Test
+    public void testAssignSameNameStateListToSoftButtonObject() {
+        List<SoftButtonState> stateListUnique = new ArrayList<>();
+        SoftButtonState softButtonState1 = new SoftButtonState("hello_there", "Hello there", null);
+        stateListUnique.add(softButtonState1);
+
+        List<SoftButtonState> stateListDuplicateNames = new ArrayList<>();
+        SoftButtonState softButtonState2 = new SoftButtonState("general_kenobi", "General Kenobi", null);
+        stateListDuplicateNames.add(softButtonState2);
+        SoftButtonState softButtonState3 = new SoftButtonState("general_kenobi", "General Kenobi Again", null);
+        stateListDuplicateNames.add(softButtonState3);
+
+        SoftButtonObject softButtonObject = new SoftButtonObject("general_kenobi", stateListUnique, "general_kenobi", null);
+
+        softButtonObject.setStates(stateListDuplicateNames);
+
+        assertEquals(stateListUnique, softButtonObject.getStates());
+    }
 }

base/src/main/java/com/smartdevicelink/managers/screen/SoftButtonObject.java

@@ -272,6 +272,11 @@ public void setStates(@NonNull List<SoftButtonState> states) {
             DebugTool.logError(TAG,"The state list is empty");
             return;
         }
+        // Make sure there aren't two states with the same name
+        if (hasTwoStatesOfSameName(states)) {
+            DebugTool.logError(TAG, "Two states have the same name in states list for soft button object");
+            return;
+        }
 
         this.states = states;
     }