bug fix

Author: sl-solution

src/byrow/byrow.jl

@@ -203,18 +203,18 @@ function byrow(ds::AbstractDataset, f::Function, cols::MultiColumnIndex; threads
 	length(colsidx) == 1 && return byrow(ds, f, colsidx[1]; threads = threads)
 	threads ?  hp_row_generic(ds, f, cols) : row_generic(ds, f, cols)
 end
-function byrow(ds::AbstractDataset, f::Function, col::ColumnIndex; threads = nrow(ds)>1000, forcemissing::Bool = true)
+function byrow(ds::AbstractDataset, f::Function, col::ColumnIndex; threads = nrow(ds)>1000, allowmissing::Bool = true)
 	if threads
 		T = Core.Compiler.return_type(f, Tuple{nonmissingtype(eltype(ds[!, col]))})
-		if forcemissing
+		if allowmissing
 			res = Vector{Union{Missing, T}}(undef, nrow(ds))
 		else
 			res = Vector{T}(undef, nrow(ds))
 		end
 		_hp_map_a_function!(res, f, _columns(ds)[index(ds)[col]])
 	else
 		T = Core.Compiler.return_type(f, Tuple{nonmissingtype(eltype(ds[!, col]))})
-		if forcemissing
+		if allowmissing
 			res = Vector{Union{Missing, T}}(undef, nrow(ds))
 		else
 			res = Vector{T}(undef, nrow(ds))

src/dataset/transpose.jl

@@ -782,7 +782,7 @@ function flatten!(ds::Dataset,
      else
         push!(all_idxcols, _columns(ds)[col1])
     end
-    lengths = byrow(Dataset(all_idxcols, [:x], copycols = false), _LENGTH, 1, threads = threads, forcemissing = false)
+    lengths = byrow(Dataset(all_idxcols, [:x], copycols = false), _LENGTH, 1, threads = threads, allowmissing = false)
     if length(idxcols) > 1
         for col in 2:length(idxcols)
              if mapformats
@@ -827,6 +827,7 @@ function flatten!(ds::Dataset,
              deleteat!(_columns(ds), idxcols_sorted[col])
              insert!(_columns(ds), idxcols_sorted[col], _res)
          end
+         removeformat!(ds, idxcols_sorted[col])
      end
      _reset_grouping_info!(ds)
      _modified(_attributes(ds))
@@ -848,7 +849,7 @@ function flatten(ds::AbstractDataset,
      else
         push!(all_idxcols, _columns(ds)[col1])
     end
-    lengths = byrow(Dataset(all_idxcols, [:x], copycols = false), _LENGTH, 1, threads = threads, forcemissing = false)
+    lengths = byrow(Dataset(all_idxcols, [:x], copycols = false), _LENGTH, 1, threads = threads, allowmissing = false)
     if length(idxcols) > 1
         for col in 2:length(idxcols)
              if mapformats