Skip to content

Commit dda0972

Browse files
committed
BUG: fix dimensionInformatonViewHelper
The render method should be declared without arguments according to the fluid core view helpers. This causes an issue while determining the root node what could potentially lead to a wrong behavior
1 parent d134170 commit dda0972

1 file changed

Lines changed: 3 additions & 5 deletions

File tree

Classes/ViewHelpers/DimensionInformationViewHelper.php

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,15 @@ public function initializeArguments()
2121
}
2222

2323
/**
24-
* @param NodeInterface $node
25-
* @param string $dimension dimension name
2624
* @return string value with replaced text
2725
* @api
2826
*/
29-
public function render(NodeInterface $node, $dimension = null)
27+
public function render()
3028
{
3129
return self::renderStatic(
3230
[
33-
'node' => $node,
34-
'dimension' => $dimension
31+
'node' => $this->arguments['node'],
32+
'dimension' => $this->arguments['dimension']
3533
],
3634
$this->buildRenderChildrenClosure(),
3735
$this->renderingContext

0 commit comments

Comments
 (0)