Repository navigation
Commit 9b58238
authored
fix(api): release-audit follow-ups for the agent API work (#9910)
* fix(api): name the failing field once in v2 validation errors
A message that already leads with its field label no longer repeats it after
the location prefix, and the CLI restates the prefix as the flag the caller
typed instead of rewriting it to query.--flag.
* fix(api): call the v2 error id requestId
The id in error bodies is the request id that x-request-id carries and logs
store as requestId; traceId already means the OTel trace id in logs, so a
search by the published value found nothing.
* fix(api): describe what the workflow outline actually omits
Only null values are dropped, every sub-block hidden from agents is dropped
(some are real configuration), and blocks whose parent container is gone are
left out, so point readers at Get workflow state for the full configuration.
* fix(api): prove the workspace schedules list against Postgres
Adds an integration suite for listWorkspaceLiveSchedulesPage: it returns the
rows the per-workflow live list reports, leaves out archived, undeployed and
other-workspace workflows, and pages through createdAt ties without repeats or
gaps. sortBy=createdAt now says that each deploy creates new schedule rows.
* chore(skills): include the optional requestId in the v2 error shape
* fix(cli): pick the handoff for --expires-in and name a refused key
sim login --expires-in without --method failed on servers that offer OAuth,
because OAuth was chosen and then refused the flag; a lifetime now selects the
API-key handoff. A refused handoff key no longer says nothing was stored: it
already exists on the account, so the CLI points at how to revoke it.
* fix(api): publish the workspace logoUrl pattern without a lookahead
RE2-based validators (Go, Rust, many gateways) reject lookaheads, so the
OpenAPI pattern for logoUrl could not be compiled there. The rewrite accepts
and refuses exactly the same values.
* chore(cli-auth): drop the poll-body half of a test that could not fail
The poll contract strips unknown keys and the route never reads them, so
sending access and expiresInDays in the body proved nothing. The test keeps
checking that the approval's access and lifetime reach the mint.
* fix(workflows): refuse withheld blocks before the operations lock
applyWorkflowOperations now hands the persistence primitive a reader, which
skipped its pre-lock withheld-block check, so a refused batch took the row lock
and re-read the graph first. The use case checks the graph it composed before
writing. A failed re-read under the lock is now an internal error instead of a
400 saying the workflow has no state.
* chore(api): document the CONFLICT 409 from Apply workflow operations
* improvement(workflows): prove the operations conflict guard against Postgres
Holds the workflow row lock to force each interleaving: an unchanged workflow
with containers and a migrated legacy block commits, a write that lands after
the base read is refused as a conflict, and of two concurrent applies one
commits and the other is refused with nothing lost.
* chore(api): tighten comments and the field-label check from review
* fix(cli): name a refused handoff key exactly
The poll response now carries the minted key's name (an additive, optional
field), so the CLI tells the caller exactly which key in Settings → API keys
to revoke, falling back to the key id for an older server. Restores the route
context argument the trimmed poll test dropped.
* fix(workflows): run the conflict-guard races on their own connections
The applies and the lock-wait poll started inside the lock holder's
transaction callback, so the transaction tripwire refused them. They now leave
that context, the applies run in a permission-group scope as routes do, and an
apply that settles early is reported without awaiting the ones queued on the
held lock.
* chore(cli-auth): declare the poll key name the server always sends
* fix(workflows): count lock waiters queued behind another waiter
A second FOR UPDATE waiter queues on the first waiter's tuple lock, so
pg_blocking_pids names that waiter rather than the holder; the barrier now
walks the chain.
* fix(cli): probe the endpoint before an --expires-in handoff
--expires-in without --method chose the handoff before the reachability
probe, so a mistyped endpoint printed a pairing code and polled instead of
failing fast. The probe now runs first. A refused key from a server that does
not report its name is described by the name pattern and time it was made.1 parent b680ad4 commit 9b58238
35 files changed
Lines changed: 780 additions & 90 deletions
File tree
- .agents/skills/v2-api-conventions
- apps
- docs
- content/docs
- api-reference
- cli
- scripts/fixtures
- sim
- app/api
- cli/auth/poll
- v2/lib
- lib
- api
- contracts
- v2
- openapi
- mcp/generated
- workflows
- application
- persistence
- triggers
- workspaces/__integration__
- packages/sim-cli/src
- auth
- commands
- generated
- runtime
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| |||
214 | 214 | | |
215 | 215 | | |
216 | 216 | | |
217 | | - | |
| 217 | + | |
218 | 218 | | |
219 | 219 | | |
220 | 220 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
175 | 175 | | |
176 | 176 | | |
177 | 177 | | |
178 | | - | |
| 178 | + | |
179 | 179 | | |
180 | 180 | | |
181 | 181 | | |
182 | 182 | | |
183 | | - | |
| 183 | + | |
184 | 184 | | |
185 | 185 | | |
186 | 186 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
86 | | - | |
| 86 | + | |
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | | - | |
| 53 | + | |
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
| |||
5126 | 5126 | | |
5127 | 5127 | | |
5128 | 5128 | | |
5129 | | - | |
| 5129 | + | |
5130 | 5130 | | |
5131 | 5131 | | |
5132 | 5132 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
| 30 | + | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
597 | 597 | | |
598 | 598 | | |
599 | 599 | | |
600 | | - | |
601 | | - | |
| 600 | + | |
| 601 | + | |
602 | 602 | | |
603 | 603 | | |
604 | 604 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4744 | 4744 | | |
4745 | 4745 | | |
4746 | 4746 | | |
4747 | | - | |
4748 | | - | |
| 4747 | + | |
| 4748 | + | |
4749 | 4749 | | |
4750 | 4750 | | |
4751 | 4751 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6049 | 6049 | | |
6050 | 6050 | | |
6051 | 6051 | | |
6052 | | - | |
6053 | | - | |
| 6052 | + | |
| 6053 | + | |
6054 | 6054 | | |
6055 | 6055 | | |
6056 | 6056 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1096 | 1096 | | |
1097 | 1097 | | |
1098 | 1098 | | |
1099 | | - | |
1100 | | - | |
| 1099 | + | |
| 1100 | + | |
1101 | 1101 | | |
1102 | 1102 | | |
1103 | 1103 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15082 | 15082 | | |
15083 | 15083 | | |
15084 | 15084 | | |
15085 | | - | |
15086 | | - | |
| 15085 | + | |
| 15086 | + | |
15087 | 15087 | | |
15088 | 15088 | | |
15089 | 15089 | | |
| |||
15266 | 15266 | | |
15267 | 15267 | | |
15268 | 15268 | | |
15269 | | - | |
| 15269 | + | |
15270 | 15270 | | |
15271 | 15271 | | |
15272 | 15272 | | |
| |||
0 commit comments