fix(knowledge): avoid overstating select-all scope

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/components/resource/selection-aware-context-menus.test.tsx

@@ -168,6 +168,25 @@ describe('selection-aware resource context menus', () => {
     expect(menu).toContain('Delete 25 items')
   })
 
+  it('does not overstate an unknown select-all toggle count', () => {
+    const menu = renderToStaticMarkup(
+      <DocumentContextMenu
+        isOpen
+        position={POSITION}
+        onClose={() => {}}
+        hasDocument
+        selectedCount={25}
+        enabledCount={25}
+        disabledCount={25}
+        hasExactToggleCount={false}
+        onToggleEnabled={() => {}}
+      />
+    )
+
+    expect(menu).toContain('Enable selected items')
+    expect(menu).not.toContain('Enable 25 items')
+  })
+
   it('counts only the chunks affected by a multi-selection toggle', () => {
     const menu = renderToStaticMarkup(
       <ChunkContextMenu

apps/sim/app/workspace/[workspaceId]/components/resource/selection-label.test.ts

@@ -43,4 +43,16 @@ describe('selection labels', () => {
       })
     ).toBe('Disable 4 items')
   })
+
+  it('keeps the action selection-aware when the affected subset count is unknown', () => {
+    expect(
+      selectionToggleActionLabel({
+        selectedCount: 10,
+        enabledCount: 10,
+        disabledCount: 10,
+        isSelectedItemEnabled: true,
+        hasExactAffectedCount: false,
+      })
+    ).toBe('Enable selected items')
+  })
 })

apps/sim/app/workspace/[workspaceId]/components/resource/selection-label.ts

@@ -22,15 +22,18 @@ interface SelectionToggleActionLabelOptions {
   enabledCount: number
   disabledCount: number
   isSelectedItemEnabled: boolean
+  hasExactAffectedCount?: boolean
 }
 
 export function selectionToggleActionLabel({
   selectedCount,
   enabledCount,
   disabledCount,
   isSelectedItemEnabled,
+  hasExactAffectedCount = true,
 }: SelectionToggleActionLabelOptions): string {
   if (selectedCount <= 1) return isSelectedItemEnabled ? 'Disable' : 'Enable'
-  if (disabledCount > 0) return selectionActionLabel('Enable', disabledCount)
-  return selectionActionLabel('Disable', enabledCount)
+  const action = disabledCount > 0 ? 'Enable' : 'Disable'
+  if (!hasExactAffectedCount) return `${action} selected items`
+  return selectionActionLabel(action, disabledCount > 0 ? disabledCount : enabledCount)
 }

apps/sim/app/workspace/[workspaceId]/knowledge/[id]/base.tsx

@@ -1505,6 +1505,7 @@ export function KnowledgeBase({
         selectedCount={selectedDocumentCount}
         enabledCount={enabledCount}
         disabledCount={disabledCount}
+        hasExactToggleCount={!isSelectAllMode || enabledFilter !== 'all'}
         onOpenInNewTab={
           contextMenuDocument && selectedDocumentCount === 1
             ? () => {

apps/sim/app/workspace/[workspaceId]/knowledge/[id]/components/document-context-menu/document-context-menu.tsx

@@ -33,6 +33,7 @@ interface DocumentContextMenuProps {
   selectedCount: number
   enabledCount?: number
   disabledCount?: number
+  hasExactToggleCount?: boolean
 }
 
 /**
@@ -60,13 +61,15 @@ export function DocumentContextMenu({
   selectedCount,
   enabledCount = 0,
   disabledCount = 0,
+  hasExactToggleCount = true,
 }: DocumentContextMenuProps) {
   const isMultiSelect = selectedCount > 1
   const toggleLabel = selectionToggleActionLabel({
     selectedCount,
     enabledCount,
     disabledCount,
     isSelectedItemEnabled: isDocumentEnabled,
+    hasExactAffectedCount: hasExactToggleCount,
   })
 
   const hasNavigationSection = !isMultiSelect && (!!onOpenInNewTab || !!onOpenSource)