|
| 1 | +import { createServer, type Server } from 'node:http' |
| 2 | +import type { AddressInfo } from 'node:net' |
| 3 | +import { db } from '@sim/db' |
| 4 | +import { account, ssoProvider, user } from '@sim/db/schema' |
| 5 | +import { emailMailerMock } from '@sim/testing/mocks/email-mailer.mock' |
| 6 | +import { emailTemplatesMock } from '@sim/testing/mocks/email-templates.mock' |
| 7 | +import { posthogServerMock } from '@sim/testing/mocks/posthog-server.mock' |
| 8 | +import { generateId } from '@sim/utils/id' |
| 9 | +import { eq, inArray } from 'drizzle-orm' |
| 10 | +import { afterAll, afterEach, beforeAll, beforeEach, describe, expect, it, vi } from 'vitest' |
| 11 | + |
| 12 | +vi.mock('@/lib/messaging/email/mailer', () => emailMailerMock) |
| 13 | +vi.mock('@/components/emails', () => emailTemplatesMock) |
| 14 | +vi.mock('@/lib/posthog/server', () => posthogServerMock) |
| 15 | + |
| 16 | +const PROVIDER_DOMAIN = 'verified-tenant.test' |
| 17 | + |
| 18 | +/** |
| 19 | + * Drives a real OIDC sign-in through Better Auth's SSO callback against PostgreSQL, with a local |
| 20 | + * IdP the tenant controls: whatever address its userinfo asserts is what the callback receives. |
| 21 | + */ |
| 22 | +describe('SSO callback user writes in PostgreSQL', () => { |
| 23 | + let auth: typeof import('@/lib/auth/auth').auth |
| 24 | + let idp: Server |
| 25 | + let idpOrigin: string |
| 26 | + let assertedEmail: string |
| 27 | + let assertedSubject: string |
| 28 | + let ownerId: string |
| 29 | + let providerId: string |
| 30 | + let createdEmails: string[] |
| 31 | + |
| 32 | + beforeAll(async () => { |
| 33 | + idp = createServer((request, response) => { |
| 34 | + response.writeHead(200, { 'content-type': 'application/json' }) |
| 35 | + if (request.url === '/token') { |
| 36 | + response.end( |
| 37 | + JSON.stringify({ |
| 38 | + access_token: 'idp-access-token', |
| 39 | + token_type: 'Bearer', |
| 40 | + expires_in: 600, |
| 41 | + }) |
| 42 | + ) |
| 43 | + return |
| 44 | + } |
| 45 | + response.end(JSON.stringify({ sub: assertedSubject, email: assertedEmail, name: 'Asserted' })) |
| 46 | + }) |
| 47 | + await new Promise<void>((resolve) => idp.listen(0, '127.0.0.1', resolve)) |
| 48 | + idpOrigin = `http://127.0.0.1:${(idp.address() as AddressInfo).port}` |
| 49 | + vi.stubEnv('SSO_ENABLED', 'true') |
| 50 | + vi.stubEnv('TRUSTED_ORIGINS', idpOrigin) |
| 51 | + ;({ auth } = await import('@/lib/auth/auth')) |
| 52 | + }, 90_000) |
| 53 | + |
| 54 | + afterAll(async () => { |
| 55 | + vi.unstubAllEnvs() |
| 56 | + await new Promise((resolve) => idp.close(resolve)) |
| 57 | + }) |
| 58 | + |
| 59 | + beforeEach(async () => { |
| 60 | + ownerId = generateId() |
| 61 | + providerId = `tenant-idp-${generateId()}` |
| 62 | + assertedSubject = generateId() |
| 63 | + createdEmails = [] |
| 64 | + const now = new Date() |
| 65 | + await db.insert(user).values({ |
| 66 | + id: ownerId, |
| 67 | + name: 'Tenant administrator', |
| 68 | + email: `${ownerId}@${PROVIDER_DOMAIN}`, |
| 69 | + emailVerified: true, |
| 70 | + createdAt: now, |
| 71 | + updatedAt: now, |
| 72 | + }) |
| 73 | + }) |
| 74 | + |
| 75 | + afterEach(async () => { |
| 76 | + await db.delete(ssoProvider).where(eq(ssoProvider.providerId, providerId)) |
| 77 | + await db.delete(user).where(eq(user.id, ownerId)) |
| 78 | + if (createdEmails.length > 0) await db.delete(user).where(inArray(user.email, createdEmails)) |
| 79 | + }) |
| 80 | + |
| 81 | + async function registerProvider(options: { overrideUserInfo?: boolean } = {}) { |
| 82 | + await db.insert(ssoProvider).values({ |
| 83 | + id: generateId(), |
| 84 | + providerId, |
| 85 | + userId: ownerId, |
| 86 | + issuer: idpOrigin, |
| 87 | + domain: PROVIDER_DOMAIN, |
| 88 | + domainVerified: true, |
| 89 | + oidcConfig: JSON.stringify({ |
| 90 | + issuer: idpOrigin, |
| 91 | + clientId: 'tenant-client', |
| 92 | + clientSecret: 'tenant-client-secret', |
| 93 | + authorizationEndpoint: `${idpOrigin}/authorize`, |
| 94 | + tokenEndpoint: `${idpOrigin}/token`, |
| 95 | + userInfoEndpoint: `${idpOrigin}/userinfo`, |
| 96 | + jwksEndpoint: `${idpOrigin}/jwks`, |
| 97 | + pkce: false, |
| 98 | + overrideUserInfo: options.overrideUserInfo ?? false, |
| 99 | + }), |
| 100 | + }) |
| 101 | + } |
| 102 | + |
| 103 | + /** Starts the sign-in, then returns from the IdP to the callback as the browser would. */ |
| 104 | + async function signInAs(email: string) { |
| 105 | + assertedEmail = email |
| 106 | + createdEmails.push(email) |
| 107 | + const started = await auth.handler( |
| 108 | + new Request('http://localhost:3000/api/auth/sign-in/sso', { |
| 109 | + method: 'POST', |
| 110 | + headers: { 'content-type': 'application/json', origin: 'http://localhost:3000' }, |
| 111 | + body: JSON.stringify({ providerId, callbackURL: '/workspace', errorCallbackURL: '/sso' }), |
| 112 | + }) |
| 113 | + ) |
| 114 | + expect(started.status).toBe(200) |
| 115 | + const { url } = (await started.json()) as { url: string } |
| 116 | + const state = new URL(url).searchParams.get('state') ?? '' |
| 117 | + expect(state).not.toBe('') |
| 118 | + const cookie = started.headers |
| 119 | + .getSetCookie() |
| 120 | + .map((value) => value.split(';')[0]) |
| 121 | + .join('; ') |
| 122 | + const callback = new URL(`http://localhost:3000/api/auth/sso/callback/${providerId}`) |
| 123 | + callback.searchParams.set('code', 'authorization-code') |
| 124 | + callback.searchParams.set('state', state) |
| 125 | + return auth.handler(new Request(callback, { headers: { cookie } })) |
| 126 | + } |
| 127 | + |
| 128 | + function redirectOf(response: Response) { |
| 129 | + expect(response.status).toBe(302) |
| 130 | + return new URL(response.headers.get('location') ?? '', 'http://localhost:3000') |
| 131 | + } |
| 132 | + |
| 133 | + async function userByEmail(email: string) { |
| 134 | + const [row] = await db.select({ id: user.id }).from(user).where(eq(user.email, email)) |
| 135 | + return row |
| 136 | + } |
| 137 | + |
| 138 | + it('creates no user or account for an asserted address outside the verified domain', async () => { |
| 139 | + await registerProvider() |
| 140 | + const victim = `ceo-${generateId()}@unverified-victim.test` |
| 141 | + |
| 142 | + const response = await signInAs(victim) |
| 143 | + |
| 144 | + expect(redirectOf(response).searchParams.get('error')).toBe('sso_provisioning_failed') |
| 145 | + expect(await userByEmail(victim)).toBeUndefined() |
| 146 | + expect( |
| 147 | + await db.select({ id: account.id }).from(account).where(eq(account.providerId, providerId)) |
| 148 | + ).toHaveLength(0) |
| 149 | + }) |
| 150 | + |
| 151 | + it('still creates the user for an asserted address inside the verified domain', async () => { |
| 152 | + await registerProvider() |
| 153 | + const member = `member-${generateId()}@${PROVIDER_DOMAIN}` |
| 154 | + |
| 155 | + const response = await signInAs(member) |
| 156 | + |
| 157 | + const redirect = redirectOf(response) |
| 158 | + expect(redirect.pathname).toBe('/workspace') |
| 159 | + expect(redirect.searchParams.has('error')).toBe(false) |
| 160 | + expect(await userByEmail(member)).toBeDefined() |
| 161 | + }) |
| 162 | + |
| 163 | + it('keeps a linked user’s email when the IdP later asserts an address outside the domain', async () => { |
| 164 | + await registerProvider({ overrideUserInfo: true }) |
| 165 | + const member = `member-${generateId()}@${PROVIDER_DOMAIN}` |
| 166 | + await signInAs(member) |
| 167 | + const linked = await userByEmail(member) |
| 168 | + expect(linked).toBeDefined() |
| 169 | + |
| 170 | + const victim = `ceo-${generateId()}@unverified-victim.test` |
| 171 | + const response = await signInAs(victim) |
| 172 | + |
| 173 | + expect(redirectOf(response).searchParams.get('error')).toBe('sso_provisioning_failed') |
| 174 | + expect(await userByEmail(member)).toEqual(linked) |
| 175 | + expect(await userByEmail(victim)).toBeUndefined() |
| 176 | + }) |
| 177 | +}) |
0 commit comments