From 631f105302bb04e072bb0c917975598ef002b53e Mon Sep 17 00:00:00 2001
From: Musa Misto <64855513+MusaMisto@users.noreply.github.com>
Date: Mon, 12 Oct 2026 14:23:47 +0300
Subject: [PATCH] fix(build): build SW.Bitween.Web once per solution build

SW.Bitween.HttpTests referenced the web project with
<Properties>SkipClientBuild=true</Properties>. MSBuild builds a project once
per set of global properties, so a solution build without that property (the
shared dotnet-build action) built SW.Bitween.Web twice, in parallel, into the
same obj folder. The two runs of DefineStaticWebAssets then collided on
rpswa.dswa.cache.json ("being used by another process"), failing the build
now and then since the HTTP tests landed: runs #118, #136, #140 and #149.

The property skipped nothing: BuildClientApp runs after
ComputeFilesToPublish, which a project reference never runs. The PR checks
pass -p:SkipClientBuild=true to every project, so there the two builds were
one and the race never showed.
---
 SW.Bitween.HttpTests/SW.Bitween.HttpTests.csproj | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/SW.Bitween.HttpTests/SW.Bitween.HttpTests.csproj b/SW.Bitween.HttpTests/SW.Bitween.HttpTests.csproj
index 0f4e4feb..4b21af6f 100644
--- a/SW.Bitween.HttpTests/SW.Bitween.HttpTests.csproj
+++ b/SW.Bitween.HttpTests/SW.Bitween.HttpTests.csproj
@@ -4,8 +4,6 @@
     <TargetFramework>net10.0</TargetFramework>
     <Nullable>enable</Nullable>
     <IsPackable>false</IsPackable>
-    <!-- The web project builds the admin UI unless told not to; these tests need only the API. -->
-    <SkipClientBuild>true</SkipClientBuild>
   </PropertyGroup>
 
   <ItemGroup>
@@ -25,9 +23,12 @@
 
   <ItemGroup>
     <ProjectReference Include="..\SW.Bitween.Cli\SW.Bitween.Cli.csproj" />
-    <ProjectReference Include="..\SW.Bitween.Web\SW.Bitween.Web.csproj">
-      <Properties>SkipClientBuild=true</Properties>
-    </ProjectReference>
+    <!-- No <Properties> on this reference. MSBuild builds a project once per set of properties, so a
+         property set here builds SW.Bitween.Web a second time beside the solution's own build of it,
+         into the same obj folder, and the two can collide on rpswa.dswa.cache.json. There is nothing
+         to skip either: the admin UI is built only on publish (BuildClientApp runs after
+         ComputeFilesToPublish), which a project reference never runs. -->
+    <ProjectReference Include="..\SW.Bitween.Web\SW.Bitween.Web.csproj" />
   </ItemGroup>
 
 </Project>