Added --all flag for dumping all tables

Author: simonw

README.md

@@ -10,4 +10,8 @@ Usage:
 
     $ sqlite-diffable dump fixtures.db out/ facetable
 
-This dumps the table called "facetable" from fixtures.db into the out/ directory.
+This dumps the table called "facetable" from fixtures.db into the out/ directory.
+
+To dump out all tables, use `--all`:
+
+    $ sqlite-diffable dump fixtures.db out/ --all

sqlite_diffable/cli.py

@@ -18,18 +18,24 @@ def cli():
 @click.argument(
     "output", type=click.Path(file_okay=False, dir_okay=True), required=True
 )
-@click.argument("tables", nargs=-1, required=True)
-def dump(path, output, tables):
+@click.argument("tables", nargs=-1, required=False)
+@click.option("--all", is_flag=True)
+def dump(path, output, tables, all):
+    if not tables and not all:
+        raise click.ClickException("You must pass --all or specify some tables")
     output = pathlib.Path(output)
     output.mkdir(exist_ok=True)
     conn = sqlite_utils.Database(path)
+    if all:
+        tables = conn.table_names()
     for table in tables:
-        filepath = output / "{}.ndjson".format(table)
-        metapath = output / "{}.metadata.json".format(table)
+        tablename = table.replace("/", "")
+        filepath = output / "{}.ndjson".format(tablename)
+        metapath = output / "{}.metadata.json".format(tablename)
         # Dump rows to filepath
         with filepath.open("w") as fp:
             for row in conn[table].rows:
-                fp.write(json.dumps(list(row.values())) + "\n")
+                fp.write(json.dumps(list(row.values()), default=repr) + "\n")
             fp.close()
         # Dump out metadata
         metapath.open("w").write(

tests/conftest.py

@@ -15,3 +15,10 @@ def one_table_db(tmpdir):
         pk="id",
     )
     return path
+
+
+@pytest.fixture
+def two_tables_db(one_table_db):
+    db = sqlite_utils.Database(one_table_db)
+    db["second_table"].insert_all([{"id": 1, "name": "Cleo"}], pk="id")
+    return one_table_db

tests/test_dump.py

@@ -22,3 +22,15 @@ def test_dump(one_table_db, tmpdir):
         "columns": ["id", "name"],
         "schema": "CREATE TABLE [one_table] (\n   [id] INTEGER PRIMARY KEY,\n   [name] TEXT\n)",
     } == json.load(metadata)
+
+
+def test_dump_all(two_tables_db, tmpdir):
+    output_dir = tmpdir / "out"
+    result = CliRunner().invoke(
+        cli.cli, ["dump", two_tables_db, str(output_dir), "--all"]
+    )
+    assert 0 == result.exit_code, result.output
+    assert (output_dir / "one_table.ndjson").exists()
+    assert (output_dir / "one_table.metadata.json").exists()
+    assert (output_dir / "second_table.ndjson").exists()
+    assert (output_dir / "second_table.metadata.json").exists()