From c73919f5e443e3241075da5c8f8e096eddf34e9f Mon Sep 17 00:00:00 2001
From: Brad Harris <bmharris@gmail.com>
Date: Wed, 16 Sep 2026 03:04:48 -0600
Subject: [PATCH] refactor(mcp): type getReviewFeedbackItem with its producer's
 return type (#tech-debt)

McpRequestContext declared the callback as returning
Promise<Record<string, unknown> | null>, while its only producer
(getFeedbackItemForAgent) returns the precise feedback-item record with
reviewId and messages. Declare the precise type so the sole consumer
(dispatch_review_get_feedback) is checked against the real shape.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
---
 apps/server/src/shared/mcp/server.ts | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/apps/server/src/shared/mcp/server.ts b/apps/server/src/shared/mcp/server.ts
index ce2dc0b2..82202574 100644
--- a/apps/server/src/shared/mcp/server.ts
+++ b/apps/server/src/shared/mcp/server.ts
@@ -535,7 +535,13 @@ export type McpRequestContext = {
   getReviewFeedbackItem?: (
     agentId: string,
     itemId: number
-  ) => Promise<Record<string, unknown> | null>;
+  ) => Promise<
+    | (ReviewFeedbackItemRecord & {
+        reviewId: number;
+        messages: ReviewThreadMessageRecord[];
+      })
+    | null
+  >;
   upsertPin?: (
     agentId: string,
     pin: McpPinInput