Merge pull request #17 from secure-web-apps/feature/fix-sonarqube-cloud-findings

Fix SonarQube Cloud findings

Author: rufer7

.github/workflows/deploy-to-azure.yml

@@ -45,7 +45,7 @@ jobs:
 
       - name: npm setup
         working-directory: ui
-        run: npm install --force
+        run: npm install --force --ignore-scripts
 
       - name: ui-angular-cli-build
         working-directory: ui

.github/workflows/dotnet-and-npm-build.yml

@@ -23,7 +23,7 @@ jobs:
 
       - name: npm setup
         working-directory: ui
-        run: npm install --force
+        run: npm install --force --ignore-scripts
 
       - name: ui-angular-cli-build
         working-directory: ui

server/Cae/CaeClaimsChallengeService.cs

@@ -10,7 +10,7 @@
 /// 
 /// This class is only required if using a standalone AuthContext check
 /// </summary>
-public class CaeClaimsChallengeService
+public static class CaeClaimsChallengeService
 {
     public static string? CheckForRequiredAuthContextIdToken(string authContextId, HttpContext context)
     {

server/Program.cs

@@ -27,7 +27,6 @@
     });
 
 services.AddScoped<MsGraphService>();
-services.AddScoped<CaeClaimsChallengeService>();
 
 services.AddAntiforgery(options =>
 {
@@ -115,11 +114,3 @@
 app.MapFallbackToPage("/_Host");
 
 await app.RunAsync();
-
-/// <summary>
-/// Expose implicitly defined Program class to the integration test project
-/// See https://learn.microsoft.com/en-us/aspnet/core/test/integration-tests?view=aspnetcore-9.0&pivots=xunit&WT.mc_id=MVP_344197#basic-tests-with-the-default-webapplicationfactory
-/// </summary>
-#pragma warning disable S1118 // Utility classes should not have public constructors
-public partial class Program { }
-#pragma warning restore S1118 // Utility classes should not have public constructors

ui/src/app/secure-api.interceptor.ts

@@ -7,7 +7,7 @@ export function secureApiInterceptor(
 ) {
   const secureRoutes = [getApiUrl()];
 
-  if (!secureRoutes.find((x) => request.url.startsWith(x))) {
+  if (!secureRoutes.some((x) => request.url.startsWith(x))) {
     return next(request);
   }