Skip to content

Commit da06493

Browse files
committed
Correct ui dialogs for preset data
1 parent fdd4081 commit da06493

4 files changed

Lines changed: 10 additions & 5 deletions

File tree

omodsim/dialogs/dialogforcemultiplecoils.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ DialogForceMultipleCoils::DialogForceMultipleCoils(ModbusWriteParams& params, QM
1515
QDialog(parent)
1616
, ui(new Ui::DialogForceMultipleCoils)
1717
,_writeParams(params)
18+
,_type(type)
1819
{
1920
ui->setupUi(this);
2021
setWindowFlags(Qt::Dialog |
@@ -110,8 +111,8 @@ void DialogForceMultipleCoils::updateTableWidget()
110111

111112
for(int i = 0; i < ui->tableWidget->rowCount(); i++)
112113
{
113-
const auto addressFrom = QString("%1").arg(_writeParams.Address + i * columns, 5, 10, QLatin1Char('0'));
114-
const auto addressTo = QString("%1").arg(_writeParams.Address + qMin(length - 1, (i + 1) * columns - 1), 5, 10, QLatin1Char('0'));
114+
const auto addressFrom = formatAddress(_type, _writeParams.Address + i * columns, false);
115+
const auto addressTo = formatAddress(_type, _writeParams.Address + qMin(length - 1, (i + 1) * columns - 1), false);
115116
ui->tableWidget->setVerticalHeaderItem(i, new QTableWidgetItem(QString("%1-%2").arg(addressFrom, addressTo)));
116117

117118
for(int j = 0; j < columns; j++)
@@ -122,7 +123,7 @@ void DialogForceMultipleCoils::updateTableWidget()
122123
auto item = new QTableWidgetItem(QString::number(_data[idx]));
123124
item->setData(Qt::UserRole, idx);
124125
item->setTextAlignment(Qt::AlignCenter);
125-
item->setToolTip(QString("%1").arg(_writeParams.Address + idx, 5, 10, QLatin1Char('0')));
126+
item->setToolTip(formatAddress(_type,_writeParams.Address + idx, false));
126127
ui->tableWidget->setItem(i, j, item);
127128
}
128129
else

omodsim/dialogs/dialogforcemultiplecoils.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ private slots:
3232
Ui::DialogForceMultipleCoils *ui;
3333
QVector<quint16> _data;
3434
ModbusWriteParams& _writeParams;
35+
QModbusDataUnit::RegisterType _type;
3536
};
3637

3738
#endif // DIALOGFORCEMULTIPLECOILS_H

omodsim/dialogs/dialogforcemultipleregisters.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ DialogForceMultipleRegisters::DialogForceMultipleRegisters(ModbusWriteParams& pa
1717
QDialog(parent)
1818
, ui(new Ui::DialogForceMultipleRegisters)
1919
,_writeParams(params)
20+
,_type(type)
2021
{
2122
ui->setupUi(this);
2223
setWindowFlags(Qt::Dialog |
@@ -356,8 +357,8 @@ void DialogForceMultipleRegisters::updateTableWidget()
356357

357358
for(int i = 0; i < ui->tableWidget->rowCount(); i++)
358359
{
359-
const auto addressFrom = QString("%1").arg(_writeParams.Address + i * columns, 5, 10, QLatin1Char('0'));
360-
const auto addressTo = QString("%1").arg(_writeParams.Address + qMin(length - 1, (i + 1) * columns - 1), 5, 10, QLatin1Char('0'));
360+
const auto addressFrom = formatAddress(QModbusDataUnit::HoldingRegisters, _writeParams.Address + i * columns, _hexView);
361+
const auto addressTo = formatAddress(QModbusDataUnit::HoldingRegisters, _writeParams.Address + qMin(length - 1, (i + 1) * columns - 1), _hexView);
361362
ui->tableWidget->setVerticalHeaderItem(i, new QTableWidgetItem(QString("%1-%2").arg(addressFrom, addressTo)));
362363

363364
for(int j = 0; j < columns; j++)

omodsim/dialogs/dialogforcemultipleregisters.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ private slots:
3737
Ui::DialogForceMultipleRegisters *ui;
3838
QVector<quint16> _data;
3939
ModbusWriteParams& _writeParams;
40+
QModbusDataUnit::RegisterType _type;
41+
bool _hexView = false;
4042
};
4143

4244
#endif // DIALOGFORCEMULTIPLEREGISTERS_H

0 commit comments

Comments
 (0)