Merge pull request #371 from salesforcecli/wr/updates

fix: overwrite file, don't create new one

Author: shetzel

messages/dev.convert.script.md

@@ -52,10 +52,6 @@ Replace flag "%s" with "%s":
 
 Can't determine the appropriate replacement for %s.
 
-# success
-
-A converted file has been written to %s.
-
 # errorComment
 
 ERROR: Unable to convert this command; you must convert it manually. 

src/commands/dev/convert/script.ts

@@ -100,13 +100,8 @@ export default class ConvertScript extends SfCommand<void> {
         data.push(line);
       }
     }
-    // write the new script as a new file with a `-converted` suffix
-    const output = `${flags.script.substring(0, flags.script.lastIndexOf('.'))}-converted${flags.script.substring(
-      flags.script.lastIndexOf('.')
-    )}`;
 
-    this.log(messages.getMessage('success', [output]));
-    fs.writeFileSync(output, data.join(os.EOL));
+    fs.writeFileSync(flags.script, data.join(os.EOL));
   }
 
   private async replaceFlag(replacement: Snapshot, line: string, prompt: boolean): Promise<string> {

yarn.lock

@@ -1578,11 +1578,6 @@
     "@types/yeoman-environment" "*"
     "@types/yeoman-generator" "*"
 
-"@types/yosay@^2.0.1":
-  version "2.0.1"
-  resolved "https://registry.yarnpkg.com/@types/yosay/-/yosay-2.0.1.tgz#320ff6ea4ba5d464a7c8ba1011d64fbf5562a1b0"
-  integrity sha512-MUFT7qfnt9f3yYAOLBupoChVUFmZkrLP6DlkruFJ560djzlgW5lX5JfqDwDfzuCzcyVdRQTNVr7dx/Up9PKTmw==
-
 "@typescript-eslint/eslint-plugin@^5.62.0":
   version "5.62.0"
   resolved "https://registry.yarnpkg.com/@typescript-eslint/eslint-plugin/-/eslint-plugin-5.62.0.tgz#aeef0328d172b9e37d9bab6dbc13b87ed88977db"