uefi: Use is_multiple_of

Author: nicholasbishop

uefi/src/allocator.rs

@@ -87,7 +87,7 @@ fn alloc_pool_aligned(memory_type: MemoryType, size: usize, align: usize) -> *mu
 ///
 /// [Rust type layout]: https://doc.rust-lang.org/reference/type-layout.html
 const fn layout_allows_page_alloc_shortcut(layout: &Layout) -> bool {
-    layout.size() % PAGE_SIZE == 0 && layout.align() == PAGE_SIZE
+    layout.size().is_multiple_of(PAGE_SIZE) && layout.align() == PAGE_SIZE
 }
 
 /// Allocator using UEFI boot services.

uefi/src/mem/aligned_buffer.rs

@@ -100,7 +100,7 @@ impl AlignedBuffer {
     /// Check the buffer's alignment against the `required_alignment`.
     pub fn check_alignment(&self, required_alignment: usize) -> Result<(), AlignmentError> {
         //TODO: use bfr.addr() when it's available
-        if (self.ptr() as usize) % required_alignment != 0 {
+        if !(self.ptr() as usize).is_multiple_of(required_alignment) {
             return Err(AlignmentError); //TODO: use >is_aligned_to< when it's available
         }
         Ok(())

uefi/src/proto/hii/config_str.rs

@@ -183,7 +183,7 @@ impl ConfigurationString {
     /// An `Option<String>` containing the parsed string.
     #[must_use]
     pub fn parse_string_from_hex(data: &str) -> Option<String> {
-        if data.len() % 2 != 0 {
+        if !data.len().is_multiple_of(2) {
             return None;
         }
         let size_bytes = data.len() / 2 + 2; // includes \0 terminator

uefi/src/proto/loaded_image.rs

@@ -75,8 +75,8 @@ impl LoadedImage {
 
         if self.0.load_options.is_null() {
             Err(LoadOptionsError::NotSet)
-        } else if (load_options_size % size_of::<u16>() != 0)
-            || (((self.0.load_options as usize) % align_of::<u16>()) != 0)
+        } else if !load_options_size.is_multiple_of(size_of::<u16>())
+            || !(self.0.load_options as usize).is_multiple_of(align_of::<u16>())
         {
             Err(LoadOptionsError::NotAligned)
         } else {