You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not all error/lints are emitted at the same time anymore, making them kinda less useful considering that you need to run and fix rustc/rustdoc multiple times to get through all of them.
For coherency with the other attribute errors, I didn't modify the default output too much, meaning that we have some new messages now. I'll likely come back to that to check if the previous ones were better in a case-by-case approach.
doc(test(attr(...))) is handled in a horrifying manner currently. Until we can handle it correctly with the Attribute system, it'll remain that thing we're all very ashamed of. 😈
Because of error reporting, some fields of Doc are suboptimal, like inline which instead of being an Option is a ThinVec because we report the error later on. Part of the things I'm not super happy about but can be postponed to future me.
From #149645
cfg_old.rsare likely unused now, so they should be removed. Remove unused code incfg_old#149903doc(test(attr(...)))is handled in a horrifying manner currently. Until we can handle it correctly with theAttributesystem, it'll remain that thing we're all very ashamed of. 😈Docare suboptimal, likeinlinewhich instead of being anOptionis aThinVecbecause we report the error later on. Part of the things I'm not super happy about but can be postponed to future me.src/librustdoc/clean/cfg.rs, thepub(crate) fn parse(cfg: &MetaItemInner) -> Result<Cfg, InvalidCfgError> {function should be removed oncecfg_tracehas been ported to newcfgAPI. [DON'T MERGE] Port#[cfg]and#[cfg_attr]trace attributes to the new attribute parsers #150092DocFragmentwent from 32 to 48. Would be nice to get it back to 32.malformed `doc` attribute inputwasn't meant for so many candidates, should be improved. If there are too many suggestions for malformed attribute, do not suggest them #149917check_attrwe can move to attribute parsingdoc(alias)on fields & patternsInvalidTargetinstead ofAttributeLintKind::AttrCrateLevelOnlyandDocAttrNotCrateLevel