Add new IANA-allocated options from draft-muks-dns-filtering#1269
Open
muks wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These new options are from the "DNS EDNS0 Option Codes (OPT)" registry in the "Domain Name System (DNS) Parameters" registry group.
https://www.iana.org/assignments/dns-parameters/dns-parameters.xhtml
Result of running the EDNS unittests on the
edns-filteringbranch:I have manually checked the Sphinx-generated HTML documentation in a web browser.
BTW, I've also added a call to
unittest.main()at the end oftest_edns.py. It does not affect the running ofutest.pyfrom theMakefile, and allows the unittests intest_edns.pyto be executed separately.Snippet of the result of running
utest.pyin the branch: