Skip to content

Commit eb30fce

Browse files
committed
test(vscode): drop the wall-clock retry assertion from the registry harness
The continuous-interruption test asserted `attempts > 1` inside a 50ms budget with 5ms retry delays. The suite runs inside the extension host during activation, so one stalled retry delay can outlast the budget and leave a correct loop at attempts=1 (Windows E2E, run 35502494622). Retrying is already proven by the interrupted-window test; this test's own point is that continuous interruption ends in a timeout.
1 parent 52dad86 commit eb30fce

1 file changed

Lines changed: 10 additions & 14 deletions

File tree

‎packages/vscode/e2e/lint/suite/registry-harness.test.ts‎

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -33,23 +33,19 @@ suite('VS Code test harness fail-closed guards', function () {
3333
});
3434

3535
test('continuous interruption times out instead of passing partially', async () => {
36-
let attempts = 0;
3736
await assert.rejects(
38-
waitForConsecutiveSuccessfulProbeWindows(
39-
async () => {
40-
attempts += 1;
41-
return false;
42-
},
43-
{
44-
consecutiveSuccessfulWindows: 2,
45-
timeoutMs: 50,
46-
retryDelayMs: 5,
47-
description: 'the continuously interrupted injected probe',
48-
},
49-
),
37+
waitForConsecutiveSuccessfulProbeWindows(async () => false, {
38+
consecutiveSuccessfulWindows: 2,
39+
timeoutMs: 50,
40+
retryDelayMs: 5,
41+
description: 'the continuously interrupted injected probe',
42+
}),
5043
/Timed out.*interruptedWindows=/,
5144
);
52-
assert.ok(attempts > 1, 'The probe should retry readiness windows');
45+
// Deviation from upstream: no `attempts > 1` assertion. Retrying is
46+
// already proven by the interrupted-window test above, and this suite runs
47+
// inside the extension host during activation, where one stalled 5ms retry
48+
// delay can outlast the 50ms budget and leave a correct loop at attempts=1.
5349
});
5450

5551
test('a non-settling probe window is bounded by the hard deadline', async () => {

0 commit comments

Comments
 (0)