unrecognized option -- -

[eedwards-sk]

Executables

Version of bash-debug: bash-3.1-0.09

Output of following commands (on windows, execute them in Command Prompt or PowerShell):

where bash:

what? Do you mean which bash?

code --version:
1.24.1
24f62626b222e9a8313213fb64b10d741a326288
x64

bash -c 'uname -a; for P in bash bashdb cat mkfifo pkill; do echo ---; which -a $P; command $P --version; done':
Darwin EEDWARDSLT-MAC.local 17.6.0 Darwin Kernel Version 17.6.0: Tue May  8 15:22:16 PDT 2018; root:xnu-4570.61.1~1/RELEASE_X86_64 x86_64
---
/bin/bash
GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin17)
Copyright (C) 2007 Free Software Foundation, Inc.
---
/usr/local/bin/bashdb
Bourne-Again Shell Debugger, release bash-3.1-0.09
Copyright 2002, 2003, 2004, 2006, 2007 Rocky Bernstein
This is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.

bashdb: cannot read program to debug: Bc:hL:nqt:T::x:XYV.
---
/bin/cat
cat: illegal option -- -
usage: cat [-benstuv] [file ...]
---
/usr/bin/mkfifo
mkfifo: illegal option -- -
usage: mkfifo [-m mode] fifoname ...
---
/usr/bin/pkill
pkill: illegal option -- -
usage: pkill [-signal] [-ILfilnovx] [-F pidfile] [-G gid]
             [-P ppid] [-U uid] [-g pgrp]
             [-t tty] [-u euid] pattern ...

Debug output

13:03:45, 2018-6-22
From client: initialize({"clientID":"vscode","clientName":"Visual Studio Code","adapterID":"bashdb","pathFormat":"path","linesStartAt1":true,"columnsStartAt1":true,"supportsVariableType":true,"supportsVariablePaging":true,"supportsRunInTerminalRequest":true,"locale":"en-us"})
To client: {"seq":0,"type":"response","request_seq":1,"command":"initialize","success":true,"body":{"supportsConditionalBreakpoints":false,"supportsConfigurationDoneRequest":false,"supportsEvaluateForHovers":true,"supportsStepBack":false,"supportsSetVariable":false}}
From client: launch({"type":"bashdb","request":"launch","name":"Bash-Debug (hardcoded script name)","cwd":"/Users/eedwards/Documents/dev/bash-util","program":"/Users/eedwards/Documents/dev/bash-util/bash-util/build/lib/bash-util-1.0/test","args":[],"showDebugOutput":true,"trace":true,"pathBash":"bash","pathBashdb":"bashdb","pathCat":"cat","pathMkfifo":"mkfifo","pathPkill":"pkill","__sessionId":"38047af9-b61e-4e71-bb4f-cd757dda6cbd"})
To client: {"seq":0,"type":"event","event":"output","body":{"category":"stdout","output":"Bourne-Again Shell Debugger, release bash-3.1-0.09\n"}}
Bourne-Again Shell Debugger, release bash-3.1-0.09
To client: {"seq":0,"type":"event","event":"output","body":{"category":"stdout","output":"Copyright 2002, 2003, 2004, 2006, 2007 Rocky Bernstein\nThis is free software, covered by the GNU General Public License, and you are\nwelcome to change it and/or distribute copies of it under certain conditions.\n\n"}}
Copyright 2002, 2003, 2004, 2006, 2007 Rocky Bernstein
This is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
To client: {"seq":0,"type":"event","event":"output","body":{"category":"stderr","output":"bashdb: cannot read program to debug: Bc:hL:nqt:T::x:XYV.\n"}}
bashdb: cannot read program to debug: Bc:hL:nqt:T::x:XYV.

Details

bashdb works fine when ran from the command line directly:

→ bash --debugger -- test
(/Users/eedwards/Documents/dev/bash-util/build/lib/bash-util-1.0/test:3):
3:	source ./bash-util.bash
bashdb<0> q

[eedwards-sk]

I got further, still having issues.

I'm running on OSX which uses BSD and doesn't support long getopt

Had to run the bashdb installation using ./configure --disable-getopt which got me past the initial error message.

However, now when running I get this:

/usr/local/bin/bashdb: unrecognized option -- -
Use --help for option help. Terminating...

debug output

13:16:19, 2018-6-22
From client: initialize({"clientID":"vscode","clientName":"Visual Studio Code","adapterID":"bashdb","pathFormat":"path","linesStartAt1":true,"columnsStartAt1":true,"supportsVariableType":true,"supportsVariablePaging":true,"supportsRunInTerminalRequest":true,"locale":"en-us"})
To client: {"seq":0,"type":"response","request_seq":1,"command":"initialize","success":true,"body":{"supportsConditionalBreakpoints":false,"supportsConfigurationDoneRequest":false,"supportsEvaluateForHovers":true,"supportsStepBack":false,"supportsSetVariable":false}}
From client: launch({"type":"bashdb","request":"launch","name":"Bash-Debug (simplest configuration)","program":"/Users/eedwards/Documents/dev/bash-util/build/lib/bash-util-1.0/test","showDebugOutput":true,"trace":true,"args":[],"cwd":"/Users/eedwards/Documents/dev/bash-util","pathBash":"bash","pathBashdb":"bashdb","pathCat":"cat","pathMkfifo":"mkfifo","pathPkill":"pkill","__sessionId":"15d52173-23da-4ed4-8d58-9d1ee84e2b91"})
To client: {"seq":0,"type":"event","event":"output","body":{"category":"stdout","output":"/usr/local/bin/bashdb: unrecognized option -- -\nUse --help for option help. Terminating...\n"}}
/usr/local/bin/bashdb: unrecognized option -- -
Use --help for option help. Terminating...

Please advise

[eedwards-sk]

I assume this may be due to installing it without getopt support.

Can you confirm if there is support for the short option names?

→ bashdb -h
_Dbg_usage:
    bashdb [OPTIONS] <script_file>

Runs script_file under a debugger.

options:
    -B           basename only on source listings. (Needed in regression tests)
    -h           print this help
    -n           Don't run initialization files
    -c command   Run this passed command as a script
    -q           Quiet. Do not print introductory and quiet messages.
    -L libdir    set directory location of library helper file: dbg-main.inc
                 the default directory is: /usr/local/share/bashdb
    -T tmpdir    set directory location for temporary files: /tmp
    -t tty       set debugger terminal
    -x cmdfile   execute debugger commands from cmdfile
    -X           set line tracing
    -Y           set line tracing with variable expansion
    -V           show version number and no-warranty and exit.

[eedwards-sk]

Also, whenever I stop the debugging process, it doesn't seem to exit properly... I have to 'reload window' for vscode to let me run it again.

[rogalmic]

This extension was developed and tested with much newer bashdb version than:

/usr/local/bin/bashdb
Bourne-Again Shell Debugger, release bash-3.1-0.09

Is there any reason for using older bash + older bashdb?

[eedwards-sk]

Yes, Mac OSX runs bash 3.2. Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Michał <notifications@github.com> Sent: Friday, June 22, 2018 1:47:34 PM To: rogalmic/vscode-bash-debug Cc: Ethan Edwards; Author Subject: Re: [rogalmic/vscode-bash-debug] unrecognized option -- - (#70) This extension was developed and tested with much newer bashdb version than: /usr/local/bin/bashdb Bourne-Again Shell Debugger, release bash-3.1-0.09 Is there any reason for using older bash + older bashdb? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#70 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/Ag-68UmCHghUbqduKuQlFjYRO11t2W3fks5t_TvGgaJpZM4U0Nl7>.

[rogalmic]

This is simplified command line used by extension:

bashdb --quiet --tty "${fifo_path}" -- ./debugged_script.sh

The -- separates bashdb args from script path and script args. Please show the output of this command line (omit the tty arg for now).

[eedwards-sk]

Hey @rogalmic thanks for your response

Here's the output:

→ bashdb --quiet -- ./test
/usr/local/bin/bashdb: unrecognized option -- -
Use --help for option help. Terminating...

I believe this confirms what I suspected, that the long option names (e.g. --quiet) are not supported.

I haven't dug into your codebase yet, so I apologize for 'taking a stab at a solution' without any real knowledge, but perhaps we could add a setting in launch.json to useShortOptionNames or similar?

Thanks in advance!

edit: also, as an amusing easter egg... with short options bashdb still prints Use --help for option help., which doesn't work! haha!

→ bashdb --help
/usr/local/bin/bashdb: unrecognized option -- -
Use --help for option help. Terminating...

[rogalmic]

:)

Maybe @wataash can help you, since I believe he is using OSX together with this vscode extension.

[wataash]

@eedwards-sk

On bashdb@7504a22, the behavior of getopt_long was changed, which was included on bashdb-4.0-0.4.

Could you try bashdb-4.4-0.92? (not 4.4-0.93 or later because of #69)
I think it can be installed without --disable-getopt.

I'll investigate it more from next week... :)

[eedwards-sk]

Thanks for the response. I must use the version I'm using. If you read the readme in the sourceforge repo for bashdb, you will see that the version of bashdb correlates to the version of bash. It's not designed to always be ran with the latest version, thus I believe a project like this would benefit from knowing how to invoke various versions. Thanks Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Wataru Ashihara <notifications@github.com> Sent: Saturday, June 23, 2018 2:21:15 AM To: rogalmic/vscode-bash-debug Cc: Ethan Edwards; Mention Subject: Re: [rogalmic/vscode-bash-debug] unrecognized option -- - (#70) @eedwards-sk<https://github.com/eedwards-sk> On bashdb@7504a22<https://sourceforge.net/p/bashdb/code/ci/7504a22/>, the behavior of getopts_long was changed, which was included on bashdb-4.0-0.4. Could you try bashdb-4.4-0.92<https://sourceforge.net/projects/bashdb/files/bashdb/> (not 4.4-0.93 or later because of #69<#69>)? I think it can be installed without --disable-getopt. I'll investigate it more from next week... :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#70 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/Ag-68Y--xT6H5DClT5jIGaLhESja_00Rks5t_exrgaJpZM4U0Nl7>.

[wataash]

Makes sense!

@rogalmic
Why don't we replace --quiet --tty with -q -t ?
Using short options seems to be necessary when using macOS's built-in /bin/bash (version 3.2.57, even on latest macOS, which requires an older version of bashdb).

[wataash]

Summary of the issue

bashdb on some environment can't parse --quiet and --tty options, thus vscode-bash-debug doesn't work.

• bashdb < 4.0-0.4 uses getopt(1) to parse arguments to bashdb
  • https://sourceforge.net/p/bashdb/code/ci/e04ca4b/tree/bashdb.in
• getopt(1) in utils-linux can parse long options, whereas built-in /usr/bin/getopt cannot (below code block below)
• Recent bashdb doesn't use getopt(1), so this problem occurs only on older bashdb.

getopt(1) on linux:

$ type getopt
getopt is /usr/bin/getopt
$ getopt --version
getopt from util-linux 2.31.1
$ getopt -o Bc:hqT: --long basename,command:,help,quiet,terminal: -n 'bashdb' -- -B --command=foo -q --terminal=bar arg
 -B --command 'foo' -q --terminal 'bar' -- 'arg'

getopt(1) on macOS:

$ type getopt
getopt is /usr/bin/getopt
$ getopt --version
 --
$ getopt -o Bc:hqT: --long basename,command:,help,quiet,terminal: -n 'bashdb' -- -B --command=foo -q --terminal=bar arg
 -- Bc:hqT: --long basename,command:,help,quiet,terminal: -n bashdb -- -B --command=foo -q --terminal=bar arg

[rogalmic]

OK, if it helps we will change that (it is quite small and safe change).

However, because of limited development resources / time release candidate testing will still be done only with newer bashdb.

[rogalmic]

Pull request with changes