From 4419d645b957931cdc7065c24fdd4d8100a60072 Mon Sep 17 00:00:00 2001 From: ABCxFF <79597906+abcxff@users.noreply.github.com> Date: Tue, 25 Aug 2026 13:18:07 -0400 Subject: [PATCH] fix(rivetkit-napi): remove stale HttpRequestBodyStream test after envoy v6 revert --- .../rivetkit-napi/tests/actor_factory.rs | 25 +------------------ 1 file changed, 1 insertion(+), 24 deletions(-) diff --git a/rivetkit-typescript/packages/rivetkit-napi/tests/actor_factory.rs b/rivetkit-typescript/packages/rivetkit-napi/tests/actor_factory.rs index 69d2705e38..ad8d18aea4 100644 --- a/rivetkit-typescript/packages/rivetkit-napi/tests/actor_factory.rs +++ b/rivetkit-typescript/packages/rivetkit-napi/tests/actor_factory.rs @@ -7,12 +7,10 @@ mod moved_tests { use parking_lot::Mutex; use rivet_error::{MacroMarker, RivetError, RivetErrorSchema}; - use rivetkit_core::HttpRequestBodyStream as CoreHttpRequestBodyStream; - use tokio::sync::{mpsc, watch}; use tracing::Level; use tracing_subscriber::fmt::MakeWriter; - use super::{BRIDGE_RIVET_ERROR_PREFIX, HttpRequestBodyStream, parse_bridge_rivet_error}; + use super::{BRIDGE_RIVET_ERROR_PREFIX, parse_bridge_rivet_error}; static AUTH_FORBIDDEN_SCHEMA: RivetErrorSchema = RivetErrorSchema { group: "auth", @@ -126,25 +124,4 @@ mod moved_tests { assert!(logs.contains("malformed BridgeRivetErrorPayload")); assert!(logs.contains("parse_err")); } - - #[tokio::test] - async fn cancelling_http_request_body_drops_core_receiver() { - let (body_tx, body_rx) = mpsc::channel(1); - let (_abort_tx, abort_rx) = watch::channel(None); - let stream = HttpRequestBodyStream::new( - Vec::new(), - CoreHttpRequestBodyStream::new(body_rx, abort_rx), - ); - - stream.cancel().await.expect("cancel request body stream"); - - assert!(body_tx.is_closed()); - assert!( - stream - .read() - .await - .expect("read cancelled request body") - .is_none() - ); - } }