diff --git a/scripts/recordMarkdown.js b/scripts/recordMarkdown.js index 163e85e96b..25cd4f8fab 100644 --- a/scripts/recordMarkdown.js +++ b/scripts/recordMarkdown.js @@ -403,9 +403,11 @@ export function commitMarkdown(r, full) { ...sectionGroups(r.sections.filter(s => !BELOW.has(s.name))).map(g => section(g.section, g.parts, full), ), + // A quote, not a `[!CAUTION]` alert: GitHub draws alerts only at the top + // level of a comment, and inside `
` shows the marker as text. ...r.sections .filter(s => s.name === "Breaking") - .map(s => `> [!CAUTION]\n> **Breaking:** ${inline(joined(s))}`), + .map(s => `> ⚠️ **Breaking:** ${inline(joined(s))}`), ]; const reviews = r.sections.filter(s => s.name === "Review"); if (reviews.length) diff --git a/scripts/recordMarkdown.test.js b/scripts/recordMarkdown.test.js index 309afb8137..bbfe695a9a 100644 --- a/scripts/recordMarkdown.test.js +++ b/scripts/recordMarkdown.test.js @@ -84,7 +84,8 @@ ${SIGNED} md, '`parse`\n\n```diff\n expression\n- Pexp_extension "raw"\n+ Pexp_raw "raw"\n```', ); - has(md, "> [!CAUTION]\n> **Breaking:** PPXs must match Pexp\\_raw."); + has(md, "> ⚠️ **Breaking:** PPXs must match Pexp\\_raw."); + assert.ok(!md.includes("[!")); has(md, "**Review**\n\n- Does a PPX still see it? Yes."); has(md, "Yes.\n\n
"); assert.ok(!md.includes("Signed-off-by"));