Skip to content

Commit 4a3b5c9

Browse files
committed
fe/sr: use encoded name for subject
We dont want %3A.test%3Acars now that we have subjects.
1 parent 1e9cedb commit 4a3b5c9

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

frontend/src/components/pages/schemas/schema-create.tsx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -204,13 +204,14 @@ export class SchemaCreatePage extends PageComponent<{ contextName?: string }> {
204204

205205
export class SchemaAddVersionPage extends PageComponent<{ subjectName: string }> {
206206
initPage(p: PageInitHelper): void {
207-
const subjectName = this.props.subjectName;
207+
const subjectName = decodeURIComponent(this.props.subjectName);
208+
const encodedSubjectName = encodeURIComponent(subjectName);
208209
p.title = 'Add schema version';
209210
p.addBreadcrumb('Schema Registry', '/schema-registry');
210-
p.addBreadcrumb(subjectName, `/schema-registry/subjects/${subjectName}`, undefined, {
211+
p.addBreadcrumb(subjectName, `/schema-registry/subjects/${encodedSubjectName}`, undefined, {
211212
canBeTruncated: true,
212213
});
213-
p.addBreadcrumb('Create schema', `/schema-registry/subjects/${subjectName}/add-version`);
214+
p.addBreadcrumb('Create schema', `/schema-registry/subjects/${encodedSubjectName}/add-version`);
214215
this.refreshData(true);
215216
appGlobal.onRefresh = () => this.refreshData(true);
216217
}
@@ -261,6 +262,7 @@ const SchemaCreatePageContent = ({ contextName }: { contextName?: string }) => {
261262
const SchemaAddVersionPageContent = ({ subjectName }: { subjectName: string }) => {
262263
const [stateData, setStateData] = useState<SchemaEditorStateData | null>(null);
263264
const subject = api.schemaDetails.get(subjectName);
265+
const srContextsEnabled = useSupportedFeaturesStore((s) => s.schemaRegistryContexts);
264266

265267
useEffect(() => {
266268
if (!subject || stateData !== null) return;
@@ -316,7 +318,7 @@ const SchemaAddVersionPageContent = ({ subjectName }: { subjectName: string }) =
316318
context: contextId,
317319
})
318320
);
319-
}, [subject, stateData]);
321+
}, [subject, stateData, srContextsEnabled]);
320322

321323
if (!subject || stateData === null) return DefaultSkeleton;
322324

0 commit comments

Comments
 (0)