sr: fix schema creation and reference with context

When creating a schema in a named context with
references to default-context subjects, the
schema registry auto prexixes unqualified
references with the parent's context. Resulting
in non-existen lookups.

Now we explicitly qualify default context
references with `:.:`.

And, in the backend we were sending a request
to createSchema which makes additional API calls
and we were only interested in the ID as part of
the response, so we now just call register and get
the ID.

Author: r-vasquez

backend/pkg/console/schema_registry.go

@@ -682,24 +682,27 @@ func (s *Service) CreateSchemaRegistrySchema(ctx context.Context, subjectName st
 		ctx = sr.WithParams(ctx, sr.Normalize)
 	}
 
-	subjectSchema, err := srClient.CreateSchema(ctx, subjectName, schema)
+	// Use RegisterSchema instead of CreateSchema to avoid a follow-up
+	// SchemaUsagesByID call that fails for named contexts (schema IDs
+	// are context-scoped, but the lookup doesn't include context).
+	schemaID, err := srClient.RegisterSchema(ctx, subjectName, schema, -1, -1)
 	if err != nil {
 		// If metadata was included and we got a parse error, retry without metadata.
 		// Older Redpanda versions don't support the metadata field.
 		if schema.SchemaMetadata != nil {
 			s.logger.WarnContext(ctx, "retrying schema creation without metadata (unsupported by this Redpanda version)",
 				slog.String("subject", subjectName))
 			schema.SchemaMetadata = nil
-			subjectSchema, err = srClient.CreateSchema(ctx, subjectName, schema)
+			schemaID, err = srClient.RegisterSchema(ctx, subjectName, schema, -1, -1)
 			if err != nil {
 				return nil, err
 			}
-			return &CreateSchemaResponse{ID: subjectSchema.ID}, nil
+			return &CreateSchemaResponse{ID: schemaID}, nil
 		}
 		return nil, err
 	}
 
-	return &CreateSchemaResponse{ID: subjectSchema.ID}, nil
+	return &CreateSchemaResponse{ID: schemaID}, nil
 }
 
 // SchemaRegistrySchemaValidation is the response to a schema validation.

frontend/src/components/pages/schemas/schema-context-utils.test.ts

@@ -13,6 +13,7 @@ import { describe, expect, test } from 'vitest';
 
 import {
   ALL_CONTEXT_ID,
+  buildQualifiedReferences,
   buildQualifiedSubjectName,
   contextNameToId,
   DEFAULT_CONTEXT_ID,
@@ -228,3 +229,40 @@ describe('pluralize', () => {
     expect(pluralize(3, 'subject')).toBe('3 subjects');
   });
 });
+
+describe('buildQualifiedReferences', () => {
+  const ref = (context: string, subject: string) => ({
+    name: 'ref1',
+    subject,
+    version: 1,
+    context,
+  });
+
+  test('default parent + default ref → unqualified subject', () => {
+    const result = buildQualifiedReferences([ref(DEFAULT_CONTEXT_ID, 'aaaa')], DEFAULT_CONTEXT_ID);
+    expect(result).toEqual([{ name: 'ref1', subject: 'aaaa', version: 1 }]);
+  });
+
+  test('named parent + same-context ref → qualified with context', () => {
+    const result = buildQualifiedReferences([ref('.supertest', 'aaaa')], '.supertest');
+    expect(result).toEqual([{ name: 'ref1', subject: ':.supertest:aaaa', version: 1 }]);
+  });
+
+  test('named parent + default ref → explicitly qualified as `:.:subject`', () => {
+    const result = buildQualifiedReferences([ref(DEFAULT_CONTEXT_ID, 'aaaa')], '.supertest');
+    expect(result).toEqual([{ name: 'ref1', subject: ':.:aaaa', version: 1 }]);
+  });
+
+  test('named parent + empty-string context ref → explicitly qualified as `:.:subject`', () => {
+    const result = buildQualifiedReferences([ref('', 'aaaa')], '.supertest');
+    expect(result).toEqual([{ name: 'ref1', subject: ':.:aaaa', version: 1 }]);
+  });
+
+  test('filters out refs with missing name or subject', () => {
+    const result = buildQualifiedReferences(
+      [ref(DEFAULT_CONTEXT_ID, ''), { name: '', subject: 'aaaa', version: 1, context: DEFAULT_CONTEXT_ID }],
+      DEFAULT_CONTEXT_ID
+    );
+    expect(result).toEqual([]);
+  });
+});

frontend/src/components/pages/schemas/schema-context-utils.ts

@@ -144,14 +144,21 @@ export function contextLabelToId(label: string): string {
 }
 
 // Build qualified references for API calls (create/validate).
+// When the parent subject is in a named context and a reference targets the
+// default context, explicitly qualify it as `:.:subject` so the SR doesn't
+// auto-prefix with the parent's context.
 export function buildQualifiedReferences(
-  refs: { name: string; subject: string; version: number; context: string }[]
+  refs: { name: string; subject: string; version: number; context: string }[],
+  parentContext: string
 ): { name: string; subject: string; version: number }[] {
   return refs
     .filter((x) => x.name && x.subject)
     .map((r) => ({
       name: r.name,
-      subject: buildQualifiedSubjectName(r.context, r.subject),
+      subject:
+        isNamedContext(parentContext) && !isNamedContext(r.context)
+          ? buildQualifiedSubjectName('.', r.subject)
+          : buildQualifiedSubjectName(r.context, r.subject),
       version: r.version,
     }));
 }

frontend/src/components/pages/schemas/schema-create.tsx

@@ -415,7 +415,7 @@ const SchemaPageButtons = (p: {
                 .createSchema(subjectName, {
                   schemaType: editorState.format as SchemaTypeType,
                   schema: editorState.schemaText,
-                  references: buildQualifiedReferences(editorState.references),
+                  references: buildQualifiedReferences(editorState.references, editorState.context),
                   metadata: editorState.computedMetadata,
                   params: {
                     normalize: editorState.normalize,
@@ -509,7 +509,7 @@ async function validateSchema(state: SchemaEditorStateHelper): Promise<{
     .validateSchema(state.qualifiedSubjectName, 'latest', {
       schemaType: state.format as SchemaTypeType,
       schema: state.schemaText,
-      references: buildQualifiedReferences(state.references),
+      references: buildQualifiedReferences(state.references, state.context),
     })
     .catch(
       (err) =>
@@ -1036,7 +1036,7 @@ const ReferencesEditor = (p: {
             ...prev,
             references: [
               ...prev.references,
-              { id: crypto.randomUUID(), name: '', subject: '', version: 1, context: '' },
+              { id: crypto.randomUUID(), name: '', subject: '', version: 1, context: p.parentContext },
             ],
           }));
         }}