Execute command#369
Closed
JPinkney wants to merge 4 commits into
Closed
Conversation
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
Member
|
Is this a WIP? |
Contributor
Author
|
Oops, yeah I meant to mark it as a draft |
Collaborator
|
Closing this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is just a P.O.C of how executing bundles could work. Essentially a "bundle" at this point is just a javascript file with 3 exports: name, version, and a map of commands to functions. There's still a lot more to do but essentially these "bundles" all you to register custom commands and actions similar to vscode-java and jdt.ls
Client-side changes: redhat-developer/vscode-yaml#403
An example extension: https://github.com/JPinkney/yaml-extension-bundle/tree/0.0.2
What issues does this PR fix or reference?
Is it tested? How?