Use modern TypeScript module resolution#1272
Merged
Merged
Conversation
This project was still using the deprecated TypeScript module resolution `node10` (aka `node`). This change updates the module resolution to `nodenext`. Imports were fixed accordingly. Notably, `yaml/dist/parse/cst` isn’t exported, but this is exported as the `CST` namespace in the `yaml` module. This is a preparation for updating to LSP 3.18, because some related packages no longer support the old module resolution anymore.
datho7561
approved these changes
Jun 8, 2026
datho7561
left a comment
datho7561
left a comment
Contributor
There was a problem hiding this comment.
Looks good and it's an important step towards es module support. Thanks, Remco!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This project was still using the deprecated TypeScript module resolution
node10(akanode). This change updates the module resolution tonodenext. Imports were fixed accordingly.Notably,
yaml/dist/parse/cstisn’t exported, but this is exported as theCSTnamespace in theyamlmodule.This is a preparation for updating to LSP 3.18, because some related packages no longer support the old module resolution anymore. It’s also a preparation to go ESM-only at some point.
What issues does this PR fix or reference?
N/A
Is it tested? How?