From aa6742a5c1826f0d40f6e93d5ad9ab95dbcee0fd Mon Sep 17 00:00:00 2001 From: Jakub Piasecki Date: Wed, 30 Sep 2026 01:22:51 -0700 Subject: [PATCH] Use public umbrellas in animationbackend headers (#58734) Summary: Route public C++ dependencies of the `react/renderer/animationbackend` headers through their supported umbrella entry points (``, ``, ``, ``, ``), so framework consumers can use the module with strict API enforcement enabled. `react/renderer/uimanager` includes are unchanged since that module has no umbrella and its headers are "for frameworks". Changelog: [Internal] Differential Revision: D122327976 --- packages/react-native/ReactCommon/React-Fabric.podspec | 4 ++++ .../react/renderer/animationbackend/AnimatedProps.h | 2 +- .../react/renderer/animationbackend/AnimatedPropsBuilder.h | 4 ++-- .../react/renderer/animationbackend/AnimatedPropsRegistry.h | 4 ++-- .../react/renderer/animationbackend/AnimationBackend.h | 4 ++-- .../renderer/animationbackend/AnimationBackendCommitHook.h | 2 +- .../react/renderer/animationbackend/AnimationChoreographer.h | 2 +- .../react/renderer/animationbackend/CMakeLists.txt | 2 ++ 8 files changed, 15 insertions(+), 9 deletions(-) diff --git a/packages/react-native/ReactCommon/React-Fabric.podspec b/packages/react-native/ReactCommon/React-Fabric.podspec index 8b84f704eef5..3cd384a8e371 100644 --- a/packages/react-native/ReactCommon/React-Fabric.podspec +++ b/packages/react-native/ReactCommon/React-Fabric.podspec @@ -72,6 +72,10 @@ Pod::Spec.new do |s| end s.subspec "animationbackend" do |ss| + ss.dependency "React-Fabric/coreUmbrella" + ss.dependency "React-Fabric/components/viewUmbrella" + ss.dependency "React-callinvoker" + ss.dependency "React-timing" ss.source_files = podspec_sources("react/renderer/animationbackend/**/*.{m,mm,cpp,h}", "react/renderer/animationbackend/**/*.{h}") ss.header_dir = "react/renderer/animationbackend" end diff --git a/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedProps.h b/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedProps.h index b9ca8c571115..c918b6d7d1b2 100644 --- a/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedProps.h +++ b/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedProps.h @@ -9,7 +9,7 @@ #include -#include +#include #include diff --git a/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedPropsBuilder.h b/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedPropsBuilder.h index 5c3ad7580c7c..ac998369a722 100644 --- a/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedPropsBuilder.h +++ b/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedPropsBuilder.h @@ -9,8 +9,8 @@ #include -#include -#include +#include +#include #include "AnimatedProps.h" namespace facebook::react { diff --git a/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedPropsRegistry.h b/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedPropsRegistry.h index 64eaa12b863a..3c004ec9502f 100644 --- a/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedPropsRegistry.h +++ b/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedPropsRegistry.h @@ -9,9 +9,9 @@ #include +#include +#include #include -#include -#include #include #include #include "AnimatedProps.h" diff --git a/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackend.h b/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackend.h index d1a7d02df118..af4a37a9c260 100644 --- a/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackend.h +++ b/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackend.h @@ -9,8 +9,8 @@ #include -#include -#include +#include +#include #include #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackendCommitHook.h b/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackendCommitHook.h index 4dd36aba3b51..fb968a659b97 100644 --- a/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackendCommitHook.h +++ b/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackendCommitHook.h @@ -9,7 +9,7 @@ #include -#include +#include #include #include #include "AnimatedPropsRegistry.h" diff --git a/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationChoreographer.h b/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationChoreographer.h index de2194382212..634ff6a57e43 100644 --- a/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationChoreographer.h +++ b/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationChoreographer.h @@ -9,8 +9,8 @@ #include +#include #include -#include namespace facebook::react { diff --git a/packages/react-native/ReactCommon/react/renderer/animationbackend/CMakeLists.txt b/packages/react-native/ReactCommon/react/renderer/animationbackend/CMakeLists.txt index e6a60cc3d4d7..02c4654f745b 100644 --- a/packages/react-native/ReactCommon/react/renderer/animationbackend/CMakeLists.txt +++ b/packages/react-native/ReactCommon/react/renderer/animationbackend/CMakeLists.txt @@ -14,6 +14,7 @@ add_library(react_renderer_animationbackend OBJECT ${react_renderer_animationbac target_include_directories(react_renderer_animationbackend PUBLIC ${REACT_COMMON_DIR}) target_link_libraries(react_renderer_animationbackend + callinvoker react_codegen_rncore react_cxxstableapi react_debug @@ -21,6 +22,7 @@ target_link_libraries(react_renderer_animationbackend react_renderer_graphics react_renderer_mounting react_renderer_uimanager + react_timing glog folly_runtime )