Include umbrella headers from jsinspector-modern (#58707)

Summary:

`jsinspector-modern` headers included three public-tier headers directly: `react/timing/primitives.h`, `react/utils/OnScopeExit.h` and `ReactCommon/RuntimeExecutor.h`. These are protected by `UmbrellaGuard.h`, so any consumer that defined `RN_STRICT_API` and included one of the affected jsinspector headers (e.g. `RuntimeTarget.h`, `HostTarget.h`, `ReactCdp.h`) hit a hard `#error`, even with `RN_ALLOW_FRAMEWORKS` defined.

Switch to the module umbrellas `<React/Timing.h>`, `<React/Utils.h>` and `<React/RuntimeExecutor.h>`, and declare the `react/timing` dependency that was previously used without being declared (BUCK, CMake, CocoaPods).

Changelog: [Internal]

Differential Revision: D122118482

Author: j-piasecki

packages/react-native/Package.swift

@@ -194,7 +194,7 @@ let reactJsInspector = RNTarget(
   name: .reactJsInspector,
   path: "ReactCommon/jsinspector-modern",
   excludedPaths: ["tracing", "network", "tests"],
-  dependencies: [.reactNativeDependencies, .reactFeatureFlags, .jsi, .reactJsInspectorTracing, .reactJsInspectorNetwork, .reactRuntimeExecutor, .reactPerfLogger],
+  dependencies: [.reactNativeDependencies, .reactFeatureFlags, .jsi, .reactJsInspectorTracing, .reactJsInspectorNetwork, .reactRuntimeExecutor, .reactPerfLogger, .reactUtils],
   defines: [
     CXXSetting.define("REACT_NATIVE_DEBUGGER_ENABLED", to: "1", .when(configuration: BuildConfiguration.debug)),
     CXXSetting.define("REACT_NATIVE_DEBUGGER_ENABLED_DEVONLY", to: "1", .when(configuration: BuildConfiguration.debug)),

packages/react-native/ReactCommon/jsinspector-modern/CMakeLists.txt

@@ -25,6 +25,7 @@ target_link_libraries(jsinspector
         jsinspector_tracing
         react_cxxstableapi
         react_featureflags
+        react_timing
         runtimeexecutor
         reactperflogger
         react_utils

packages/react-native/ReactCommon/jsinspector-modern/HostTargetTraceRecording.h

@@ -13,12 +13,12 @@
 #include "HostTarget.h"
 #include "InstanceTarget.h"
 
+#include <React/Timing.h>
 #include <jsinspector-modern/tracing/FrameTimingSequence.h>
 #include <jsinspector-modern/tracing/HostTracingProfile.h>
 #include <jsinspector-modern/tracing/TimeWindowedBuffer.h>
 #include <jsinspector-modern/tracing/TraceRecordingState.h>
 #include <jsinspector-modern/tracing/TracingCategory.h>
-#include <react/timing/primitives.h>
 
 #include <optional>
 #include <set>

packages/react-native/ReactCommon/jsinspector-modern/React-jsinspector.podspec

@@ -55,6 +55,7 @@ Pod::Spec.new do |s|
   add_dependency(s, "React-jsinspectortracing", :framework_name => 'jsinspector_moderntracing')
   s.dependency "React-perflogger", version
   s.dependency "React-cxxstableapi"
+  s.dependency "React-timing"
   add_dependency(s, "React-oscompat")
   add_dependency(s, "React-utils", :additional_framework_paths => ["react/utils/platform/ios"])
   if use_hermes()

packages/react-native/ReactCommon/jsinspector-modern/RuntimeTarget.h

@@ -18,7 +18,7 @@
 #include "StackTrace.h"
 #include "WeakList.h"
 
-#include <ReactCommon/RuntimeExecutor.h>
+#include <React/RuntimeExecutor.h>
 #include <jsinspector-modern/tracing/RuntimeSamplingProfile.h>
 #include <jsinspector-modern/tracing/TraceRecordingState.h>
 

packages/react-native/ReactCommon/jsinspector-modern/ScopedExecutor.h

@@ -9,7 +9,7 @@
 
 #include <react/cxxstableapi/FrameworksGuard.h>
 
-#include <react/utils/OnScopeExit.h>
+#include <React/Utils.h>
 #include <cassert>
 #include <functional>
 #include <memory>

packages/react-native/ReactCommon/jsinspector-modern/TracingAgent.h

@@ -12,10 +12,10 @@
 #include "HostTarget.h"
 #include "InspectorInterfaces.h"
 
+#include <React/Timing.h>
 #include <jsinspector-modern/cdp/CdpJson.h>
 #include <jsinspector-modern/tracing/HostTracingProfile.h>
 #include <jsinspector-modern/tracing/Timing.h>
-#include <react/timing/primitives.h>
 
 namespace facebook::react::jsinspector_modern {