Skip to content

Commit 6259bd2

Browse files
coadometa-codesync[bot]
authored andcommitted
Add explicit renderer CSS dependencies (#58522)
Summary: Pull Request resolved: #58522 Declare direct CSS dependencies for renderer targets that consume CSS headers instead of relying on View or Graphics to expose them transitively. Cover Buck, CMake, CocoaPods, and SwiftPM without changing header visibility or runtime behavior. Changelog: [Internal] Reviewed By: javache Differential Revision: D119489856
1 parent 7ca1b42 commit 6259bd2

6 files changed

Lines changed: 18 additions & 3 deletions

File tree

‎packages/react-native/Package.swift‎

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -288,21 +288,29 @@ let reactJsErrorHandler = RNTarget(
288288
dependencies: [.reactNativeDependencies, .jsi, .reactFeatureFlags, .reactDebug, .reactTurboModuleBridging]
289289
)
290290

291+
/// React-renderercss.podspec
292+
let reactRendererCss = RNTarget(
293+
name: .reactRendererCss,
294+
path: "ReactCommon/react/renderer/css",
295+
excludedPaths: ["tests"],
296+
dependencies: [.reactNativeDependencies, .reactDebug, .reactUtils]
297+
)
298+
291299
/// React-graphicsApple
292300
/// This represents the React-graphicsApple BUCK module
293301
let reactGraphicsApple = RNTarget(
294302
name: .reactGraphicsApple,
295303
path: "ReactCommon/react/renderer/graphics/platform/ios",
296304
linkedFrameworks: ["UIKit", "CoreGraphics"],
297-
dependencies: [.reactDebug, .jsi, .reactUtils, .reactNativeDependencies]
305+
dependencies: [.reactDebug, .jsi, .reactUtils, .reactNativeDependencies, .reactRendererCss]
298306
)
299307

300308
/// React-graphics.podspec
301309
let reactGraphics = RNTarget(
302310
name: .reactGraphics,
303311
path: "ReactCommon/react/renderer/graphics",
304312
excludedPaths: ["platform", "tests"],
305-
dependencies: [.reactNativeDependencies, .jsi, .reactJsiExecutor, .reactRendererDebug, .reactUtils, .reactGraphicsApple]
313+
dependencies: [.reactNativeDependencies, .jsi, .reactJsiExecutor, .reactRendererDebug, .reactUtils, .reactGraphicsApple, .reactRendererCss]
306314
)
307315

308316
/// ReactCommon.podspec
@@ -492,7 +500,7 @@ let reactFabric = RNTarget(
492500
"observers/resize/tests",
493501
"scheduler/tests",
494502
],
495-
dependencies: [.reactNativeDependencies, .reactJsiExecutor, .rctTypesafety, .reactTurboModuleCore, .jsi, .logger, .reactDebug, .reactFeatureFlags, .reactUtils, .reactRuntimeScheduler, .reactCxxReact, .reactRendererDebug, .reactGraphics, .yoga, .reactJsInspectorTracing],
503+
dependencies: [.reactNativeDependencies, .reactJsiExecutor, .rctTypesafety, .reactTurboModuleCore, .jsi, .logger, .reactDebug, .reactFeatureFlags, .reactUtils, .reactRuntimeScheduler, .reactCxxReact, .reactRendererDebug, .reactGraphics, .reactRendererCss, .yoga, .reactJsInspectorTracing],
496504
sources: ["animated", "animationbackend", "animations", "attributedstring", "core", "componentregistry", "componentregistry/native", "components/root", "components/view", "components/view/platform/cxx", "components/scrollview", "components/scrollview/platform/cxx", "components/scrollview/platform/ios", "components/legacyviewmanagerinterop", "components/legacyviewmanagerinterop/platform/ios", "dom", "scheduler", "mounting", "observers/events", "observers/intersection", "observers/mutation", "observers/resize", "telemetry", "consistency", "leakchecker", "uimanager", "uimanager/consistency", "viewtransition"]
497505
)
498506

@@ -714,6 +722,7 @@ let targets = [
714722
reactPerformanceTimeline,
715723
reactRuntimeScheduler,
716724
rctTypesafety,
725+
reactRendererCss,
717726
reactGraphics,
718727
reactGraphicsApple,
719728
reactImageManager,

‎packages/react-native/ReactCommon/React-Fabric.podspec‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ Pod::Spec.new do |s|
7777
end
7878

7979
s.subspec "attributedstring" do |ss|
80+
ss.dependency "React-renderercss"
8081
ss.source_files = podspec_sources("react/renderer/attributedstring/**/*.{m,mm,cpp,h}", "react/renderer/attributedstring/**/*.{h}")
8182
ss.exclude_files = "react/renderer/attributedstring/tests"
8283
ss.header_dir = "react/renderer/attributedstring"
@@ -217,6 +218,7 @@ Pod::Spec.new do |s|
217218
end
218219

219220
ss.subspec "intersection" do |sss|
221+
sss.dependency "React-renderercss"
220222
sss.source_files = podspec_sources("react/renderer/observers/intersection/**/*.{m,mm,cpp,h}", "react/renderer/observers/intersection/**/*.h")
221223
sss.exclude_files = "react/renderer/observers/intersection/tests"
222224
sss.header_dir = "react/renderer/observers/intersection"

‎packages/react-native/ReactCommon/react/renderer/attributedstring/CMakeLists.txt‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ target_link_libraries(react_renderer_attributedstring
2121
react_debug
2222
rrc_view
2323
react_renderer_core
24+
react_renderer_css
2425
react_renderer_debug
2526
react_renderer_graphics
2627
react_renderer_mapbuffer

‎packages/react-native/ReactCommon/react/renderer/graphics/CMakeLists.txt‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ target_link_libraries(react_renderer_graphics
3232
folly_runtime
3333
react_cxxstableapi
3434
react_debug
35+
react_renderer_css
3536
react_renderer_debug
3637
react_utils
3738
)

‎packages/react-native/ReactCommon/react/renderer/graphics/React-graphics.podspec‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ Pod::Spec.new do |s|
5757
s.dependency "React-utils"
5858
s.dependency "React-rendererdebug"
5959
s.dependency "React-cxxstableapi"
60+
s.dependency "React-renderercss"
6061

6162
depend_on_js_engine(s)
6263
add_rn_third_party_dependencies(s)

‎packages/react-native/ReactCommon/react/renderer/observers/intersection/CMakeLists.txt‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ target_link_libraries(react_renderer_observers_intersection
1919
react_cxxstableapi
2020
react_debug
2121
react_renderer_core
22+
react_renderer_css
2223
react_renderer_graphics
2324
react_renderer_mounting
2425
react_renderer_runtimescheduler

0 commit comments

Comments
 (0)