Skip to content

Commit 2fc65e8

Browse files
j-piaseckimeta-codesync[bot]
authored andcommitted
Use umbrella instead of a direct include in bridging module (#58549)
Summary: Pull Request resolved: #58549 Changelog: [Internal] Update the bridging module to use `React/Bridging.h` and `React/RendererCore.h` umbrella includes instead of direct ones. Reviewed By: cipolleschi Differential Revision: D120311601 fbshipit-source-id: 31449979bdbee83362e3d0352d3d46bca2097435
1 parent d0078c2 commit 2fc65e8

9 files changed

Lines changed: 13 additions & 8 deletions

File tree

‎packages/react-native/ReactApple/RCTAnimatedModuleProvider/React-RCTAnimatedModuleProvider.podspec‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ Pod::Spec.new do |s|
5555
s.dependency "React-Fabric/animated"
5656
s.dependency "Yoga"
5757

58+
add_dependency(s, "React-Fabric")
5859
add_dependency(s, "ReactCommon", :subspec => "turbomodule/core", :additional_framework_paths => ["react/nativemodule/core"])
5960

6061
depend_on_js_engine(s)

‎packages/react-native/ReactCommon/react/nativemodule/defaults/React-defaultsnativemodule.podspec‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ Pod::Spec.new do |s|
5959
s.dependency "React-webperformancenativemodule"
6060
s.dependency "React-Fabric/animated"
6161
s.dependency "React-cxxstableapi"
62+
add_dependency(s, "React-Fabric")
6263
add_dependency(s, "React-RCTFBReactNativeSpec")
6364
add_dependency(s, "React-featureflags")
6465
add_dependency(s, "React-featureflagsnativemodule")

‎packages/react-native/ReactCommon/react/nativemodule/dom/React-domnativemodule.podspec‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ Pod::Spec.new do |s|
5252
s.dependency "Yoga"
5353
s.dependency "ReactCommon/turbomodule/core"
5454
s.dependency "React-bridging"
55-
s.dependency "React-Fabric"
55+
add_dependency(s, "React-Fabric")
5656
s.dependency "React-Fabric/bridging"
5757
s.dependency "React-FabricComponents"
5858
s.dependency "React-cxxstableapi"

‎packages/react-native/ReactCommon/react/nativemodule/intersectionobserver/React-intersectionobservernativemodule.podspec‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ Pod::Spec.new do |s|
5757
s.dependency "ReactCommon/turbomodule/core"
5858
s.dependency "React-bridging"
5959

60-
s.dependency "React-Fabric"
60+
add_dependency(s, "React-Fabric")
6161
s.dependency "React-Fabric/bridging"
6262
s.dependency "React-runtimescheduler"
6363
s.dependency "React-cxxstableapi"

‎packages/react-native/ReactCommon/react/nativemodule/mutationobserver/React-mutationobservernativemodule.podspec‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ Pod::Spec.new do |s|
5757
s.dependency "ReactCommon/turbomodule/core"
5858
s.dependency "React-bridging"
5959

60-
s.dependency "React-Fabric"
60+
add_dependency(s, "React-Fabric")
6161
s.dependency "React-Fabric/bridging"
6262
s.dependency "React-Fabric/observers/mutation"
6363
s.dependency "React-featureflags"

‎packages/react-native/ReactCommon/react/nativemodule/resizeobserver/React-resizeobservernativemodule.podspec‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ Pod::Spec.new do |s|
5757
s.dependency "ReactCommon/turbomodule/core"
5858
s.dependency "React-bridging"
5959

60-
s.dependency "React-Fabric"
60+
add_dependency(s, "React-Fabric")
6161
s.dependency "React-Fabric/bridging"
6262
s.dependency "React-Fabric/observers/resize"
6363
s.dependency "React-runtimescheduler"

‎packages/react-native/ReactCommon/react/nativemodule/viewtransition/React-viewtransitionnativemodule.podspec‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ Pod::Spec.new do |s|
5151

5252
s.dependency "Yoga"
5353
s.dependency "ReactCommon/turbomodule/core"
54-
s.dependency "React-Fabric"
54+
add_dependency(s, "React-Fabric")
5555
s.dependency "React-Fabric/bridging"
5656
add_dependency(s, "React-runtimeexecutor", :additional_framework_paths => ["platform/ios"])
5757
add_dependency(s, "React-RCTFBReactNativeSpec")

‎packages/react-native/ReactCommon/react/renderer/bridging/CMakeLists.txt‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@ add_library(react_renderer_bridging INTERFACE)
1212

1313
target_include_directories(react_renderer_bridging INTERFACE ${REACT_COMMON_DIR})
1414

15-
target_link_libraries(react_renderer_bridging INTERFACE react_cxxstableapi)
15+
target_link_libraries(react_renderer_bridging INTERFACE
16+
react_bridging
17+
react_cxxstableapi
18+
react_renderer_core)
1619
target_compile_reactnative_options(react_renderer_bridging INTERFACE)
1720
target_compile_options(react_renderer_bridging INTERFACE -Wpedantic)

‎packages/react-native/ReactCommon/react/renderer/bridging/bridging.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99

1010
#include <react/cxxstableapi/FrameworksGuard.h>
1111

12+
#include <React/Bridging.h>
13+
#include <React/RendererCore.h>
1214
#include <jsi/jsi.h>
13-
#include <react/bridging/Base.h>
14-
#include <react/renderer/core/ShadowNode.h>
1515

1616
namespace facebook::react {
1717

0 commit comments

Comments
 (0)