Skip to content

Commit 24fd31e

Browse files
j-piaseckifacebook-github-bot
authored andcommitted
Use module umbrella headers in react/renderer/animations (#58728)
Summary: Headers in `react/renderer/animations` included fine-grained public headers from other modules that are protected by `UmbrellaGuard.h`, which hard-errors under `RN_STRICT_API` unless included through the module umbrella. Switch these includes to the corresponding umbrellas: - `react/renderer/core/ReactPrimitives.h` -> `React/RendererCore.h` - `react/renderer/core/RawValue.h` -> `React/RawValue.h` - `react/renderer/debug/flags.h` -> `React/RendererDebug.h` - `react/renderer/graphics/Float.h` -> `React/Graphics.h` - `ReactCommon/RuntimeExecutor.h` -> `React/RuntimeExecutor.h` For-frameworks headers (`mounting`, `uimanager`) have no umbrella and are left as-is. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D122311313
1 parent d194d8b commit 24fd31e

4 files changed

Lines changed: 7 additions & 7 deletions

File tree

‎packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationDriver.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99

1010
#include <react/cxxstableapi/FrameworksGuard.h>
1111

12+
#include <React/RendererCore.h>
1213
#include <react/renderer/animations/LayoutAnimationKeyFrameManager.h>
13-
#include <react/renderer/core/ReactPrimitives.h>
1414
#include <react/renderer/mounting/ShadowViewMutation.h>
1515

1616
namespace facebook::react {

‎packages/react-native/ReactCommon/react/renderer/animations/LayoutAnimationKeyFrameManager.h‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,11 @@
99

1010
#include <react/cxxstableapi/FrameworksGuard.h>
1111

12-
#include <ReactCommon/RuntimeExecutor.h>
12+
#include <React/RawValue.h>
13+
#include <React/RendererDebug.h>
14+
#include <React/RuntimeExecutor.h>
1315
#include <react/renderer/animations/LayoutAnimationCallbackWrapper.h>
1416
#include <react/renderer/animations/primitives.h>
15-
#include <react/renderer/core/RawValue.h>
16-
#include <react/renderer/debug/flags.h>
1717
#include <react/renderer/mounting/MountingOverrideDelegate.h>
1818
#include <react/renderer/mounting/MountingTransaction.h>
1919
#include <react/renderer/mounting/ShadowViewMutation.h>

‎packages/react-native/ReactCommon/react/renderer/animations/primitives.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99

1010
#include <react/cxxstableapi/FrameworksGuard.h>
1111

12+
#include <React/Graphics.h>
13+
#include <React/RendererCore.h>
1214
#include <react/renderer/animations/LayoutAnimationCallbackWrapper.h>
13-
#include <react/renderer/core/ReactPrimitives.h>
14-
#include <react/renderer/graphics/Float.h>
1515
#include <react/renderer/mounting/ShadowView.h>
1616
#include <react/renderer/mounting/ShadowViewMutation.h>
1717
#include <vector>

‎packages/react-native/ReactCommon/react/renderer/animations/utils.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99

1010
#include <react/cxxstableapi/FrameworksGuard.h>
1111

12+
#include <React/Graphics.h>
1213
#include <react/renderer/animations/primitives.h>
13-
#include <react/renderer/graphics/Float.h>
1414
#include <react/renderer/mounting/ShadowViewMutation.h>
1515

1616
namespace facebook::react {

0 commit comments

Comments
 (0)