From 94959bbd7c27f07caac47bac5c2d86d1098ae70c Mon Sep 17 00:00:00 2001 From: Mike Perry Yeboah Attara <31483629+mikeattara@users.noreply.github.com> Date: Fri, 23 Nov 2018 06:03:18 +0000 Subject: [PATCH 1/8] Update available-scripts.md This is to solve issue #5805 --- docusaurus/docs/available-scripts.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docusaurus/docs/available-scripts.md b/docusaurus/docs/available-scripts.md index a6a32751926..188709c3ed8 100644 --- a/docusaurus/docs/available-scripts.md +++ b/docusaurus/docs/available-scripts.md @@ -30,6 +30,8 @@ See the section about [deployment](deployment.md) for more information. If you aren’t satisfied with the build tool and configuration choices, you can `eject` at any time. This command will remove the single build dependency from your project. -Instead, it will copy all the configuration files and the transitive dependencies (Webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except `eject` will still work, but they will point to the copied scripts so you can tweak them. At this point you’re on your own. +Instead, it will copy all the configuration files and the transitive dependencies (Webpack, Babel, ESLint, etc) right into your project as dependencies in `package.json`. You have full control over them and can always rearrange `package.json` as you deem reasonable. + +All of the commands except `eject` will still work, but they will point to the copied scripts so you can tweak them. At this point, you’re on your own. You don’t have to ever use `eject`. The curated feature set is suitable for small and middle deployments, and you shouldn’t feel obligated to use this feature. However we understand that this tool wouldn’t be useful if you couldn’t customize it when you are ready for it. From 079c3cb5262f4dc2ef776d87da87e7862b4aae2c Mon Sep 17 00:00:00 2001 From: Mike Perry Yeboah Attara <31483629+mikeattara@users.noreply.github.com> Date: Fri, 23 Nov 2018 06:09:28 +0000 Subject: [PATCH 2/8] Update available-scripts.md Added the link to more elaborate resource --- docusaurus/docs/available-scripts.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docusaurus/docs/available-scripts.md b/docusaurus/docs/available-scripts.md index 188709c3ed8..37c79e0f358 100644 --- a/docusaurus/docs/available-scripts.md +++ b/docusaurus/docs/available-scripts.md @@ -30,7 +30,7 @@ See the section about [deployment](deployment.md) for more information. If you aren’t satisfied with the build tool and configuration choices, you can `eject` at any time. This command will remove the single build dependency from your project. -Instead, it will copy all the configuration files and the transitive dependencies (Webpack, Babel, ESLint, etc) right into your project as dependencies in `package.json`. You have full control over them and can always rearrange `package.json` as you deem reasonable. +Instead, it will copy all the configuration files and the transitive dependencies (Webpack, Babel, ESLint, etc) right into your project as dependencies in `package.json`. You have full control over them and can always rearrange `package.json` as you deem reasonable. You can read [more here](https://stackoverflow.com/questions/44868453/create-react-app-install-devdepencies-in-dependencies-section) All of the commands except `eject` will still work, but they will point to the copied scripts so you can tweak them. At this point, you’re on your own. From 469a519fa28020ea053d1c703a7746283bd42622 Mon Sep 17 00:00:00 2001 From: Mike Perry Yeboah Attara <31483629+mikeattara@users.noreply.github.com> Date: Fri, 23 Nov 2018 15:58:18 +0000 Subject: [PATCH 3/8] Update available-scripts.md Update the reason and remove the link to stackoverflow --- docusaurus/docs/available-scripts.md | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/docusaurus/docs/available-scripts.md b/docusaurus/docs/available-scripts.md index 37c79e0f358..e6fa0ad04d8 100644 --- a/docusaurus/docs/available-scripts.md +++ b/docusaurus/docs/available-scripts.md @@ -30,7 +30,13 @@ See the section about [deployment](deployment.md) for more information. If you aren’t satisfied with the build tool and configuration choices, you can `eject` at any time. This command will remove the single build dependency from your project. -Instead, it will copy all the configuration files and the transitive dependencies (Webpack, Babel, ESLint, etc) right into your project as dependencies in `package.json`. You have full control over them and can always rearrange `package.json` as you deem reasonable. You can read [more here](https://stackoverflow.com/questions/44868453/create-react-app-install-devdepencies-in-dependencies-section) +Instead, it will copy all the configuration files and the transitive dependencies (Webpack, Babel, ESLint, etc) right into your project as dependencies in `package.json`. + +The distinction is pretty arbitrary for front-end apps that produce static bundles. Technically you don't need any of these dependencies on the server, not even the runtime ones. So by that logic even react might be seen as a development dependency. + +We used to try to separate them but as explained above, it isn't really consistent in the first place. There's no technical reason why this distinction is useful for apps that have no Node runtime. In addition, it used to cause problems for some Heroku deployments that didn't install development dependencies (and thus weren't able to build the project on the server or test it right before deployment). + +You have full control over them and can always rearrange `package.json` as you deem reasonable. All of the commands except `eject` will still work, but they will point to the copied scripts so you can tweak them. At this point, you’re on your own. From 0458f76c1e07d5763dc36dbc73d90ead986d484d Mon Sep 17 00:00:00 2001 From: Mike Perry Yeboah Attara <31483629+mikeattara@users.noreply.github.com> Date: Fri, 23 Nov 2018 16:01:46 +0000 Subject: [PATCH 4/8] Update available-scripts.md --- docusaurus/docs/available-scripts.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docusaurus/docs/available-scripts.md b/docusaurus/docs/available-scripts.md index e6fa0ad04d8..fd259065385 100644 --- a/docusaurus/docs/available-scripts.md +++ b/docusaurus/docs/available-scripts.md @@ -32,7 +32,7 @@ If you aren’t satisfied with the build tool and configuration choices, you can Instead, it will copy all the configuration files and the transitive dependencies (Webpack, Babel, ESLint, etc) right into your project as dependencies in `package.json`. -The distinction is pretty arbitrary for front-end apps that produce static bundles. Technically you don't need any of these dependencies on the server, not even the runtime ones. So by that logic even react might be seen as a development dependency. +We put them all in `dependencies` because distinction between `dependencies` and `devDependencies` is pretty arbitrary for front-end apps that produce static bundles. Technically you don't need any of these dependencies on the server, not even the runtime ones. So by that logic even react might be seen as a development dependency. We used to try to separate them but as explained above, it isn't really consistent in the first place. There's no technical reason why this distinction is useful for apps that have no Node runtime. In addition, it used to cause problems for some Heroku deployments that didn't install development dependencies (and thus weren't able to build the project on the server or test it right before deployment). From 5b48852dd3239113f9407aee71ee635087ac8b79 Mon Sep 17 00:00:00 2001 From: Mike Perry Yeboah Attara <31483629+mikeattara@users.noreply.github.com> Date: Fri, 23 Nov 2018 16:02:17 +0000 Subject: [PATCH 5/8] Update available-scripts.md --- docusaurus/docs/available-scripts.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docusaurus/docs/available-scripts.md b/docusaurus/docs/available-scripts.md index fd259065385..410d82ca33a 100644 --- a/docusaurus/docs/available-scripts.md +++ b/docusaurus/docs/available-scripts.md @@ -32,7 +32,7 @@ If you aren’t satisfied with the build tool and configuration choices, you can Instead, it will copy all the configuration files and the transitive dependencies (Webpack, Babel, ESLint, etc) right into your project as dependencies in `package.json`. -We put them all in `dependencies` because distinction between `dependencies` and `devDependencies` is pretty arbitrary for front-end apps that produce static bundles. Technically you don't need any of these dependencies on the server, not even the runtime ones. So by that logic even react might be seen as a development dependency. +We put them all in `dependencies` because the distinction between `dependencies` and `devDependencies` is pretty arbitrary for front-end apps that produce static bundles. Technically you don't need any of these dependencies on the server, not even the runtime ones. So by that logic even react might be seen as a development dependency. We used to try to separate them but as explained above, it isn't really consistent in the first place. There's no technical reason why this distinction is useful for apps that have no Node runtime. In addition, it used to cause problems for some Heroku deployments that didn't install development dependencies (and thus weren't able to build the project on the server or test it right before deployment). From a4fcd05c738e6bc46155a11b9cf2c2f1accac23f Mon Sep 17 00:00:00 2001 From: Mike Perry Yeboah Attara <31483629+mikeattara@users.noreply.github.com> Date: Fri, 23 Nov 2018 16:11:13 +0000 Subject: [PATCH 6/8] Update available-scripts.md update to reflect consistency in language choice --- docusaurus/docs/available-scripts.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docusaurus/docs/available-scripts.md b/docusaurus/docs/available-scripts.md index 410d82ca33a..6a8fc0b0389 100644 --- a/docusaurus/docs/available-scripts.md +++ b/docusaurus/docs/available-scripts.md @@ -32,7 +32,7 @@ If you aren’t satisfied with the build tool and configuration choices, you can Instead, it will copy all the configuration files and the transitive dependencies (Webpack, Babel, ESLint, etc) right into your project as dependencies in `package.json`. -We put them all in `dependencies` because the distinction between `dependencies` and `devDependencies` is pretty arbitrary for front-end apps that produce static bundles. Technically you don't need any of these dependencies on the server, not even the runtime ones. So by that logic even react might be seen as a development dependency. +We put them all in dependencies because the distinction between dependencies and development dependencies is pretty arbitrary for front-end apps that produce static bundles. Technically you don't need any of these dependencies on the server, not even the runtime ones. So by that logic even `react` might be seen as a development dependency. We used to try to separate them but as explained above, it isn't really consistent in the first place. There's no technical reason why this distinction is useful for apps that have no Node runtime. In addition, it used to cause problems for some Heroku deployments that didn't install development dependencies (and thus weren't able to build the project on the server or test it right before deployment). From 338f468e7f347a64860a07a54621c533cf66c975 Mon Sep 17 00:00:00 2001 From: Mike Perry Yeboah Attara <31483629+mikeattara@users.noreply.github.com> Date: Sat, 1 Dec 2018 23:13:26 +0000 Subject: [PATCH 7/8] Update available-scripts.md add explanation --- docusaurus/docs/available-scripts.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docusaurus/docs/available-scripts.md b/docusaurus/docs/available-scripts.md index 6a8fc0b0389..8c088353322 100644 --- a/docusaurus/docs/available-scripts.md +++ b/docusaurus/docs/available-scripts.md @@ -28,7 +28,7 @@ See the section about [deployment](deployment.md) for more information. **Note: this is a one-way operation. Once you `eject`, you can’t go back!** -If you aren’t satisfied with the build tool and configuration choices, you can `eject` at any time. This command will remove the single build dependency from your project. +If you aren’t satisfied with the build tool and configuration choices, you can `eject` at any time. This command will remove the single build dependency from your project. Instead, it will copy all the configuration files and the transitive dependencies (Webpack, Babel, ESLint, etc) right into your project as dependencies in `package.json`. From 4be39ea02e2618707f62d333d1c01ca251d38b40 Mon Sep 17 00:00:00 2001 From: Mike Perry Yeboah Attara <31483629+mikeattara@users.noreply.github.com> Date: Sun, 2 Dec 2018 05:39:46 +0000 Subject: [PATCH 8/8] Update available-scripts.md formatting --- docusaurus/docs/available-scripts.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docusaurus/docs/available-scripts.md b/docusaurus/docs/available-scripts.md index 8c088353322..23cc9b7d18b 100644 --- a/docusaurus/docs/available-scripts.md +++ b/docusaurus/docs/available-scripts.md @@ -34,7 +34,9 @@ Instead, it will copy all the configuration files and the transitive dependencie We put them all in dependencies because the distinction between dependencies and development dependencies is pretty arbitrary for front-end apps that produce static bundles. Technically you don't need any of these dependencies on the server, not even the runtime ones. So by that logic even `react` might be seen as a development dependency. -We used to try to separate them but as explained above, it isn't really consistent in the first place. There's no technical reason why this distinction is useful for apps that have no Node runtime. In addition, it used to cause problems for some Heroku deployments that didn't install development dependencies (and thus weren't able to build the project on the server or test it right before deployment). +We used to try to separate them but as explained above, it isn't really consistent in the first place. There's no technical reason why this distinction is useful for apps that have no Node runtime. + +In addition, it used to cause problems for some Heroku deployments that didn't install development dependencies (and thus weren't able to build the project on the server or test it right before deployment). You have full control over them and can always rearrange `package.json` as you deem reasonable.