Lte 2904 debug#317
Open
rajkamal-cv wants to merge 12 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts platform/init behavior around LTE/debug flows, DHCP self-heal ownership, firewall handling, and removes remaining Voice MTA-specific default/firewall handling.
Changes:
- Removes Voice MTA syscfg/default/firewall rule handling.
- Disables dnsmasq pmon registration/telemetry when DHCP Manager owns self-heal.
- Adds WNXL11BWL sshd debug logging and a non-Comcast TR-069 firewall allow rule.
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
source/scripts/init/src/apply_system_defaults/apply_system_defaults.c |
Removes Voice MTA partner default/syscfg handling. |
source/scripts/init/service.d/service_sshd.sh |
Adds WNXL11BWL sshd startup debug logging. |
source/scripts/init/c_registration/15_dhcp_server.c |
Guards dhcp_server pmon registration when DHCP Manager is enabled. |
source/pmon/pmon.c |
Guards dnsmasq restart telemetry for DHCP Manager builds. |
source/firewall/firewall.c |
Adds non-Comcast TR-069 allow rule and removes Voice MTA firewall rule injection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| fi | ||
| elif [ "$BOX_TYPE" = "WNXL11BWL" ]; then | ||
| echo_t "[utopia] devicemode `deviceinfo.sh -mode`" | ||
| echo_t "[utopia] route `route -n`" |
| if [ -n "$WAITED_IP" ]; then | ||
| echo_t "[utopia] $IFACE got IP $WAITED_IP, restarting ${SERVICE_NAME}" | ||
| rm -f "$WAIT_FOR_IP_LOCKFILE" | ||
| /etc/utopia/service.d/service_sshd.sh ${SERVICE_NAME}-restart |
Comment on lines
+145
to
+149
| if [ -f "$WAIT_FOR_IP_LOCKFILE" ]; then | ||
| echo_t "[utopia] wait_for_iface_ip already running for $IFACE, skipping" | ||
| return 1 | ||
| fi | ||
| touch "$WAIT_FOR_IP_LOCKFILE" |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
source/scripts/init/service.d/service_sshd.sh:475
- A new
remote_ssh_server_ipevent is handled above, but the Usage string in the default case does not mention it. Update the Usage text so it reflects the supported events/commands.
remote_ssh_server_ip)
if [ "$BOX_TYPE" = "WNXL11BWL" ]; then
service_stop
service_start
fi
;;
*)
echo "Usage: $SELF_NAME [${SERVICE_NAME}-start|${SERVICE_NAME}-stop|${SERVICE_NAME}-restart|ssh_server_restart|lan-status|wan-status]" >&2
exit 3
Comment on lines
+211
to
+213
| echo_t "[utopia] devicemode `deviceinfo.sh -mode`" | ||
| echo_t "[utopia] route `route -n`" | ||
| echo_t "[utopia] CMINTERFACE $CMINTERFACE " |
Comment on lines
215
to
221
| CM_IPv6=`ip -6 addr show dev wwan0 scope global | awk '/inet/{print $2}' | cut -d '/' -f1 | head -n1` | ||
| if [ ! -z $CM_IPv6 ]; then | ||
| if [ ! -z "$CM_IPv6" ]; then | ||
| commandString="$commandString -p [$CM_IPv6]:22" | ||
| fi | ||
| CM_IPv4=`ip -4 addr show dev wwan0 scope global | awk '/inet/{print $2}' | cut -d '/' -f1 | head -n1` | ||
| if [ ! -z $CM_IPv4 ]; then | ||
| if [ ! -z "$CM_IPv4" ]; then | ||
| commandString="$commandString -p [$CM_IPv4]:22" |
| sleep $SLEEP_INTERVAL | ||
| WAITED_IP=`ip -4 addr show dev $IFACE scope global | awk '/inet/{print $2}' | cut -d '/' -f1` | ||
| if [ -n "$WAITED_IP" ]; then | ||
| echo_t "[utopia] $IFACE got IP $WAITED_IP after $((RETRIES * SLEEP_INTERVAL)) seconds" |
| local MAX_RETRIES=150 # 150 x 2s = 300s max wait | ||
| while [ $RETRIES -lt $MAX_RETRIES ]; do | ||
| sleep $SLEEP_INTERVAL | ||
| WAITED_IP=`ip -4 addr show dev $IFACE scope global | awk '/inet/{print $2}' | cut -d '/' -f1` |
Comment on lines
+234
to
+236
| echo_t "[utopia] devicemode `deviceinfo.sh -mode`" | ||
| echo_t "[utopia] route `route -n`" | ||
| echo_t "[utopia] CMINTERFACE $CMINTERFACE " |
Comment on lines
+246
to
+248
| if [ "$CMINTERFACE" != "wwan0" ]; then | ||
| CM_IP=`ip -4 addr show dev $CMINTERFACE scope global | awk '/inet/{print $2}' | cut -d '/' -f1 | head -n1` | ||
| if [ ! -z "$CM_IP" ]; then |
Comment on lines
+505
to
+509
| mesh_wan_linkstatus) | ||
| if [ "$BOX_TYPE" = "WNXL11BWL" ]; then | ||
| echo_t "mesh_wan_linkstatus_value $2" | ||
| echo_t "mesh_wan_linkstatus_sysevent `sysevent get mesh_wan_linkstatus`" | ||
| if [ "$2" = "up" ]; then |
Comment on lines
+54
to
56
| #if defined(_WNXL11BWL_PRODUCT_REQ_) | ||
| "mesh_wan_linkstatus|/etc/utopia/service.d/service_sshd.sh", | ||
| #endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.