From b4dcda2edef54b49863911a27db3b2f3b9ff97f6 Mon Sep 17 00:00:00 2001 From: Rakesh Kota Date: Thu, 16 Jul 2026 18:08:05 +0530 Subject: [PATCH] ARM: dts: qcom: revert back pmic-arb to the LEVEL trigger setting Traditionally on all targets PMIC-ARB top-level IRQ (coming out from GIC to CPU) was LEVEL triggered. However, for Shikra target this had to be changed to EDGE, as the GIC input IRQ from the PMIC-ARB HW block was changed to EDGE by HW team. Without it, the input/output trigger type mismatch was leading to SPMI irqs not work. However, when the VDDMIN(APPS suspend) path was enabled, the USB detection was failing after VDDMIN exit. This was happening because during the VDDMIN exit, the IRQs are relayed from the MPM (rather than GIC), and when the exit happens, there is a window, where the IRQs were missed due to the EDGE trigger logic, by the GIC, and it appears because of that all the subsequent IRQs are missed. To fix this HW team has recommended to switch back to the LEVEL setting. So, add the needed DT change for it. Note - A corresponding change will be added in the TZ code as well, to make the PMIC-ARB -> GIC HW block LEVEL trigger. Change-Id: I907149dd3ce18ec4b10bf8874eaa18ae0faa87c5 Signed-off-by: Rakesh Kota --- arch/arm64/boot/dts/qcom/shikra.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/shikra.dtsi b/arch/arm64/boot/dts/qcom/shikra.dtsi index 35da3bc18fd13..9e6e24805d57d 100644 --- a/arch/arm64/boot/dts/qcom/shikra.dtsi +++ b/arch/arm64/boot/dts/qcom/shikra.dtsi @@ -1391,7 +1391,7 @@ "obsrvr", "intr", "cnfg"; - interrupts-extended = <&mpm 86 IRQ_TYPE_EDGE_RISING>; + interrupts-extended = <&mpm 86 IRQ_TYPE_LEVEL_HIGH>; interrupt-names = "periph_irq"; interrupt-controller; #interrupt-cells = <4>;