Removed unnecessary checks

radarhere · radarhere · commit 5554e778bba5 · 2025-07-05T13:44:02.000+10:00
diff --git a/src/libImaging/AlphaComposite.c b/src/libImaging/AlphaComposite.c
@@ -25,13 +25,11 @@ ImagingAlphaComposite(Imaging imDst, Imaging imSrc) {
     int x, y;
 
     /* Check arguments */
-    if (!imDst || !imSrc || strcmp(imDst->mode, "RGBA") ||
-        imDst->type != IMAGING_TYPE_UINT8 || imDst->bands != 4) {
+    if (!imDst || !imSrc || strcmp(imDst->mode, "RGBA")) {
         return ImagingError_ModeError();
     }
 
-    if (strcmp(imDst->mode, imSrc->mode) || imDst->type != imSrc->type ||
-        imDst->bands != imSrc->bands || imDst->xsize != imSrc->xsize ||
+    if (strcmp(imDst->mode, imSrc->mode) || imDst->xsize != imSrc->xsize ||
         imDst->ysize != imSrc->ysize) {
         return ImagingError_Mismatch();
     }

Original file line number	Diff line number	Diff line change
`@@ -25,13 +25,11 @@ ImagingAlphaComposite(Imaging imDst, Imaging imSrc) {`
`25`	`25`	`int x, y;`
`26`	`26`
`27`	`27`	`/* Check arguments */`
`28`		`- if (!imDst \|\| !imSrc \|\| strcmp(imDst->mode, "RGBA") \|\|`
`29`		`- imDst->type != IMAGING_TYPE_UINT8 \|\| imDst->bands != 4) {`
	`28`	`+ if (!imDst \|\| !imSrc \|\| strcmp(imDst->mode, "RGBA")) {`
`30`	`29`	`return ImagingError_ModeError();`
`31`	`30`	`}`
`32`	`31`
`33`		`- if (strcmp(imDst->mode, imSrc->mode) \|\| imDst->type != imSrc->type \|\|`
`34`		`- imDst->bands != imSrc->bands \|\| imDst->xsize != imSrc->xsize \|\|`
	`32`	`+ if (strcmp(imDst->mode, imSrc->mode) \|\| imDst->xsize != imSrc->xsize \|\|`
`35`	`33`	`imDst->ysize != imSrc->ysize) {`
`36`	`34`	`return ImagingError_Mismatch();`
`37`	`35`	`}`