Cast to UINT32 before shifting bits

radarhere · radarhere · commit 1d4cda65cf31 · 2025-10-09T21:01:17.000+11:00
diff --git a/src/libImaging/SgiRleDecode.c b/src/libImaging/SgiRleDecode.c
@@ -22,7 +22,8 @@
 
 static void
 read4B(UINT32 *dest, UINT8 *buf) {
-    *dest = (UINT32)((buf[0] << 24) | (buf[1] << 16) | (buf[2] << 8) | buf[3]);
+    *dest = ((UINT32)buf[0] << 24) | ((UINT32)buf[1] << 16) | ((UINT32)buf[2] << 8) |
+            buf[3];
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,8 @@`
`22`	`22`
`23`	`23`	`static void`
`24`	`24`	`read4B(UINT32 dest, UINT8 buf) {`
`25`		`- *dest = (UINT32)((buf[0] << 24) \| (buf[1] << 16) \| (buf[2] << 8) \| buf[3]);`
	`25`	`+ *dest = ((UINT32)buf[0] << 24) \| ((UINT32)buf[1] << 16) \| ((UINT32)buf[2] << 8) \|`
	`26`	`+ buf[3];`
`26`	`27`	`}`
`27`	`28`
`28`	`29`	`/*`