Link with QR

[UserX404]

Related to pyload/pyload@8fa0049 what do you think about fully integraged link for Android App with QR code?
With combined Url, Port, API, ...

As a long-term plan, a more accessible “Link-Mobile” setting, with a link to F-Droid and a direct QR code to scan in the app.
With a QR link that automatically logs in the currently logged-in user.

I remembered about an intent issue with a different app in the past what i want to share here. Just in case we want to support external QR scanner.
https://community.yatse.tv/t/remove-hard-dependancy-on-ancient-barcode-reader/4530/6

[GammaC0de]

Everything i basically ready and works, one issue i want consult with you:
For the QR code to be recognized as a URL it has to start with http(s) scheme.
So I use a redirector to pass the server info to the App (see https://github.com/GammaC0de/GammaC0de.github.io/blob/master/qr-redirector/index.html).
The question is:
Do I host the redirector on :

1. https://pyload.github.io (don't worry no sensitive info is passed to the server since it uses the hash part of the URL to pass the argument - only the requesting client see it, see https://share.gemini.google/4VPlol4gWOSv) so it is available from everywhere
2. Hot it on the pyload instance and you have to make sure you access pyload from a valid public url, not from local lan address(pyload will pass window.location.host as a host) - useful for the privacy paranoid the since it does not involve outside redirector

[UserX404]

I can just speak for myself. In the past i had a external url but have changed it to local only and use vpn connetion to connect from my mobile.
I remember i could have used both back then, internal an external url to access from internal network.

For me the local instance option would fit my needs very well. For my setup i would use the local url.
But to make it clear to the user the used url could also be printed above the presented QR.
I'm not common about the used method of geting the url. Is it just about requesting the frontend to provide the url it was opened with?

Just an additional idea as i saw your code snippet: you redirect to github release, is it possible to provide a selection? (Github, Fdroid)

[GammaC0de]

Done
0fd40df
pyload/pyload@5f593a5

[UserX404]

@GammaC0de
As there is no ticket I want to provide feedback here.
Pls reopen the discussion while we polish stuff.

Android:

• Not possible to delete the previously used default server while it's the only server configured.

• First i had no idea how to add with QR. Do you think add a QR-icon and start the QR scanner within the add-server menu?

• issues with linking

  • previous settings:
    Address: local host name -> forwarded by local dns to server IP
    port 58001 (nginx routes 58001 to 8000 docker)
    prefix: empty
    ssl: disable
    check ssl cert: disable
  • settings after qr-link
    Address: same local hostname
    port 443
    ssl: enable
    check ssl cert: enable

  I think i circumvented the nginx route because of the cert issue.
  At the server setting for Webinterface "Use HTTPS:" is set to "off" and i haven't installed a cert as nginx terminates my SSL.
  After editing all settings back manually and backing out to main screen, a pop-up appears with "path prefix seems to be wrong (404 not found)" with every sync cycle.
  I also tested with opening http, local IP and port 58001, all parameters looks like before and correct. The same pop-up comes up again and no connection could be established.

  I know pyload could not know about the outside world when it comes to external reverse proxies but with all parameter added manually it seems there is an additional issue?

Server:

• QR has changed but not the surrounding.
  You may add a note about "Scan with your device to be linked" or similar.

• After "I've saved my key" i would expect a button with Done instead of Cancel

• For testing purpose the place to generate the QR is ok but maybe think about a different, easier to reach location for managing.
  e.g. from the main screen

[UserX404]

Messed around a bit more...
It looks like the very first server has this prefix issue.
I manually created a second one with exact the same values and it's working.
It doesn't matter if using the host ip or dns name.

If i switch second server back to ssl and 443 I get this failure.

Note that I installed my own CA cert on my phone and it's accepted from my browser. Just in case it matters.

[UserX404]

• API deletion dialog

Cancel text gets black only when hovering

When clicking the bottom orange Cancel instead, the dialog don't resets itself. So when clicking the bottom Cancel and enter Manage API keys again the dialog shows Are you sure you want to delete this API key? instead ofthe API list.
I'll also suggest to don't show the parents dialogs Cancel and Generate buttons in the deletion confirmation dialog

• API generation
  The presented QR is really small and it's size could be 4 times bigger than the actual presentation.

• QR-Link-Button

Suggestions:

• Use a QR- instead of a barcode-symbol

• Adjust the circle size to the same size of the other circle

• Place the QR button next (right) to the manual-add button to not waste potential vertical space (if someone have a huge server list)

• For me, linking with the in-app QR-scanner went smoothly and without issues. I really like that the QR flow allows manually editing afterwards and is just pre-filling the data.